Enable exceptions on AnalyzerInformation::mOutputStream

Author: samopolacek

lib/analyzerinfo.cpp

@@ -23,13 +23,28 @@
 #include "utils.h"
 
 #include <tinyxml2.h>
+#include <cassert>
 #include <cstring>
 #include <map>
 #include <sstream> // IWYU pragma: keep
 
+AnalyzerInformation::AnalyzerInformation()
+{
+    mOutputStream.exceptions(std::ios_base::failbit | std::ios_base::badbit);
+}
+
 AnalyzerInformation::~AnalyzerInformation()
 {
-    close();
+    try
+    {
+        close();
+    }
+    catch (const std::ios_base::failure&)
+    {
+        assert(false);
+
+        // TODO: Report error
+    }
 }
 
 static std::string getFilename(const std::string &fullpath)
@@ -66,7 +81,6 @@ void AnalyzerInformation::writeFilesTxt(const std::string &buildDir, const std::
 
 void AnalyzerInformation::close()
 {
-    mAnalyzerInfoFile.clear();
     if (mOutputStream.is_open()) {
         mOutputStream << "</analyzerinfo>\n";
         mOutputStream.close();
@@ -139,14 +153,13 @@ bool AnalyzerInformation::analyzeFile(const std::string &buildDir, const std::st
     if (skipAnalysis(mAnalyzerInfoFile, hash, errors))
         return false;
 
-    // TODO: enable exceptions on the ofstream and remove all .is_open() calls?
     mOutputStream.open(mAnalyzerInfoFile);
-    if (mOutputStream.is_open()) {
-        mOutputStream << "<?xml version=\"1.0\"?>\n";
-        mOutputStream << "<analyzerinfo hash=\"" << hash << "\">\n";
-    } else {
-        mAnalyzerInfoFile.clear();
-    }
+    // If we ever disable exceptions on mOutputStream
+    // TODO: add this assert to all ofstreams
+    assert(mOutputStream.is_open());
+
+    mOutputStream << "<?xml version=\"1.0\"?>\n";
+    mOutputStream << "<analyzerinfo hash=\"" << hash << "\">\n";
 
     return true;
 }

lib/analyzerinfo.h

@@ -49,6 +49,7 @@ class ErrorMessage;
  */
 class CPPCHECKLIB AnalyzerInformation {
 public:
+    AnalyzerInformation();
     ~AnalyzerInformation();
 
     static void writeFilesTxt(const std::string &buildDir, const std::list<std::string> &sourcefiles, const std::string &userDefines, const std::list<ImportProject::FileSettings> &fileSettings);