assert flawed known value usage

Author: firewave

lib/valueflow.cpp

@@ -7019,6 +7019,7 @@ static void valueFlowDynamicBufferSize(const TokenList& tokenlist, const SymbolD
         case Library::AllocFunc::BufferSize::strdup:
             if (arg1 && arg1->hasKnownValue()) {
                 const ValueFlow::Value& value = arg1->values().back();
+                assert(value.isKnown());
                 if (value.isTokValue() && value.tokvalue->tokType() == Token::eString)
                     sizeValue = Token::getStrLength(value.tokvalue) + 1; // Add one for the null terminator
             }
@@ -7279,7 +7280,10 @@ const ValueFlow::Value *ValueFlow::valueFlowConstantFoldAST(Token *expr, const S
         valueFlowConstantFoldAST(expr->astOperand2(), settings);
         valueFlowSetConstantValue(expr, settings);
     }
-    return expr && expr->hasKnownValue() ? &expr->values().front() : nullptr;
+    const auto* v = expr && expr->hasKnownValue() ? &expr->values().front() : nullptr;
+    if (v)
+        assert(v->isKnown());
+    return v;
 }
 
 struct ValueFlowState {

lib/vf_settokenvalue.cpp

@@ -393,6 +393,7 @@ namespace ValueFlow
             // is condition always true/false?
             if (parent->astOperand1()->hasKnownValue()) {
                 const Value &condvalue = parent->astOperand1()->values().front();
+                assert(condvalue.isKnown());
                 const bool cond(condvalue.isTokValue() || (condvalue.isIntValue() && condvalue.intvalue != 0));
                 if (cond && !tok->astOperand1()) { // true condition, no second operator
                     setTokenValue(parent, condvalue, settings);