Fix #14667 Stack overflow in ValueType::getSizeOf()

Author: web-flow

lib/symboldatabase.cpp

@@ -8508,7 +8508,7 @@ static size_t bitCeil(size_t x)
 
 static size_t getAlignOf(const ValueType& vt, const Settings& settings, ValueType::Accuracy accuracy, ValueType::SizeOf sizeOf, int maxRecursion = 0)
 {
-    if (maxRecursion == settings.vfOptions.maxAlignOfRecursion) {
+    if (maxRecursion > settings.vfOptions.maxAlignOfRecursion) {
         // TODO: add bailout message
         return 0;
     }
@@ -8539,7 +8539,7 @@ static size_t getAlignOf(const ValueType& vt, const Settings& settings, ValueTyp
 
 size_t ValueType::getSizeOf( const Settings& settings, Accuracy accuracy, SizeOf sizeOf, int maxRecursion) const
 {
-    if (maxRecursion == settings.vfOptions.maxSizeOfRecursion) {
+    if (maxRecursion > settings.vfOptions.maxSizeOfRecursion) {
         // TODO: add bailout message
         return 0;
     }

test/testother.cpp

@@ -11683,6 +11683,19 @@ class TestOther : public TestFixture {
               "void f(S<char, 3> s) {}\n");
         ASSERT_EQUALS("", errout_str());
 
+        check("struct T {\n" // #14667
+               "    U u1, u2;\n"
+               "    union {\n"
+               "        enum { E0, E1 } e;\n"
+               "        U u3;\n"
+               "        T i;\n"
+               "    } x;\n"
+               "};\n"
+               "T f(T t) {\n"
+               "    return t;\n"
+               "}");
+        ASSERT_EQUALS("", errout_str()); // don't crash
+
         Settings settingsUnix32 = settingsBuilder().platform(Platform::Type::Unix32).build();
         check("struct S {\n" // #13850
               "    int i0 : 32;\n"