donate-cpu.py: fixed stupid mistakes in client version update notification (#4290)

Author: firewave

tools/donate-cpu.py

@@ -233,7 +233,7 @@ def get_client_version_head():
                 p = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.DEVNULL)
                 try:
                     comm = p.communicate()
-                    return comm[1]
+                    return comm[0].decode(encoding='utf-8', errors='ignore').strip()
                 except:
                     return None
 
@@ -288,6 +288,6 @@ def get_client_version_head():
         upload_info(package, info_output, server_address)
     if not max_packages or packages_processed < max_packages:
         print('Sleep 5 seconds..')
-        if (client_version_head is not None) and (StrictVersion(client_version_head) >= StrictVersion(get_client_version())):
+        if (client_version_head is not None) and (StrictVersion(client_version_head) > StrictVersion(get_client_version())):
             print("ATTENTION: A newer client version ({}) is available - please update!".format(client_version_head))
         time.sleep(5)

tools/donate_cpu_lib.py

@@ -15,7 +15,7 @@
 # Version scheme (MAJOR.MINOR.PATCH) should orientate on "Semantic Versioning" https://semver.org/
 # Every change in this script should result in increasing the version number accordingly (exceptions may be cosmetic
 # changes)
-CLIENT_VERSION = "1.3.28"
+CLIENT_VERSION = "1.3.29"
 
 # Timeout for analysis with Cppcheck in seconds
 CPPCHECK_TIMEOUT = 30 * 60