valueflow.cpp: avoid unnecessary copies in valueFlowFunctionReturn()

firewave · firewave · commit a83890862309 · 2025-06-29T17:40:43.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5990,10 +5990,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg
         if (programMemory.empty() && !arguments.empty())
             continue;
         std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);
-        for (const ValueFlow::Value& v : values) {
+        for (ValueFlow::Value& v : values) {
             if (v.isUninitValue())
                 continue;
-            setFunctionReturnValue(function, tok, v, settings);
+            setFunctionReturnValue(function, tok, std::move(v), settings);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5990,10 +5990,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg`
`5990`	`5990`	`if (programMemory.empty() && !arguments.empty())`
`5991`	`5991`	`continue;`
`5992`	`5992`	`std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);`
`5993`		`- for (const ValueFlow::Value& v : values) {`
	`5993`	`+ for (ValueFlow::Value& v : values) {`
`5994`	`5994`	`if (v.isUninitValue())`
`5995`	`5995`	`continue;`
`5996`		`- setFunctionReturnValue(function, tok, v, settings);`
	`5996`	`+ setFunctionReturnValue(function, tok, std::move(v), settings);`
`5997`	`5997`	`}`
`5998`	`5998`	`}`
`5999`	`5999`	`}`