Skip to content

Commit b01f392

Browse files
committed
fixed misc-override-with-different-visibility clang-tidy warnings
1 parent a8f8e2b commit b01f392

4 files changed

Lines changed: 11 additions & 9 deletions

File tree

gui/checkthread.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,6 @@ class CheckThread : public QThread {
7878
mSuppressionsUi = s;
7979
}
8080

81-
/**
82-
* @brief method that is run in a thread
83-
*
84-
*/
85-
void run() override;
86-
8781
void stop();
8882

8983
/**
@@ -137,6 +131,12 @@ class CheckThread : public QThread {
137131
std::shared_ptr<Suppressions> mSuppressions;
138132

139133
private:
134+
/**
135+
* @brief method that is run in a thread
136+
*
137+
*/
138+
void run() override;
139+
140140
void runAddonsAndTools(const Settings& settings, const FileSettings *fileSettings, const QString &fileName);
141141

142142
void parseClangErrors(const QString &tool, const QString &file0, QString err);

gui/resultstree.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ class ResultsTree : public QTreeView {
204204
*/
205205
ShowTypes mShowSeverities;
206206

207-
void keyPressEvent(QKeyEvent *event) override;
208-
209207
void setReportType(ReportType reportType);
210208

211209
/**
@@ -559,6 +557,8 @@ protected slots:
559557
bool mVisibleErrors{};
560558

561559
private:
560+
void keyPressEvent(QKeyEvent *event) override;
561+
562562
/** tag selected items */
563563
void tagSelectedItems(const QString &tag);
564564

gui/translationhandler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ struct TranslationInfo {
5959
* track which translation is the currently active translation.
6060
*
6161
*/
62-
class TranslationHandler : QObject {
62+
class TranslationHandler : public QObject {
6363
Q_OBJECT
6464
public:
6565
explicit TranslationHandler(QObject *parent = nullptr);

lib/vf_analyzers.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1235,6 +1235,7 @@ struct SingleValueFlowAnalyzer : ValueFlowAnalyzer {
12351235
return false;
12361236
}
12371237

1238+
private:
12381239
ValuePtr<Analyzer> reanalyze(Token* tok, const std::string& msg) const override {
12391240
ValueFlow::Value newValue = value;
12401241
newValue.errorPath.emplace_back(tok, msg);
@@ -1433,6 +1434,7 @@ struct SubExpressionAnalyzer : ExpressionAnalyzer {
14331434
partialReads->emplace_back(tok, v);
14341435
}
14351436

1437+
private:
14361438
// No reanalysis for subexpression
14371439
ValuePtr<Analyzer> reanalyze(Token* /*tok*/, const std::string& /*msg*/) const override {
14381440
return {};

0 commit comments

Comments
 (0)