Skip to content

Commit b959c11

Browse files
authored
Fixed #12369 (GUI: Compliance report for Misra C++ 2008) (#5900)
1 parent d0a02bb commit b959c11

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

gui/compliancereportdialog.cpp

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -96,17 +96,13 @@ ComplianceReportDialog::ComplianceReportDialog(ProjectFile* projectFile, QString
9696
mUI->mEditProjectName->setText(projectFile->getProjectName());
9797
connect(mUI->buttonBox, &QDialogButtonBox::clicked, this, &ComplianceReportDialog::buttonClicked);
9898
mUI->mCodingStandard->clear();
99-
if (projectFile->getCodingStandards().contains("misra-c-2023"))
100-
mUI->mCodingStandard->addItem("Misra C 2023");
101-
else if (projectFile->getAddons().contains("misra"))
99+
if (!projectFile->getCodingStandards().contains("misra-c-2023") && projectFile->getAddons().contains("misra"))
102100
mUI->mCodingStandard->addItem("Misra C 2012");
103-
if (projectFile->getCodingStandards().contains("misra-c++-2008"))
104-
mUI->mCodingStandard->addItem("Misra C++ 2008");
105-
if (projectFile->getCodingStandards().contains("cert-c-2016"))
106-
mUI->mCodingStandard->addItem("Cert C");
107-
if (projectFile->getCodingStandards().contains("cert-c++-2016"))
108-
mUI->mCodingStandard->addItem("Cert C++");
109-
mUI->mCodingStandard->addItems(projectFile->getCodingStandards());
101+
for (QString std: projectFile->getCodingStandards()) {
102+
std[0] = std[0].toUpper();
103+
std = std.replace("-", " ").replace(" c ", " C ").replace(" cpp ", " C++ ").replace(" c++ ", " C++ ");
104+
mUI->mCodingStandard->addItem(std);
105+
}
110106
}
111107

112108
ComplianceReportDialog::~ComplianceReportDialog()

gui/mainwindow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1359,7 +1359,7 @@ void MainWindow::enableCheckButtons(bool enable)
13591359
mUI->mActionAnalyzeDirectory->setEnabled(enable);
13601360

13611361
if (isCppcheckPremium()) {
1362-
mUI->mActionComplianceReport->setEnabled(enable && mProjectFile && mProjectFile->getAddons().contains("misra"));
1362+
mUI->mActionComplianceReport->setEnabled(enable && mProjectFile && (mProjectFile->getAddons().contains("misra") || !mProjectFile->getCodingStandards().empty()));
13631363
}
13641364
}
13651365

0 commit comments

Comments
 (0)