Fix #12368 FP constParameterReference with std::mutex (f'up to #5882) (#5898)

Author: chrchr-github

lib/astutils.cpp

@@ -2475,7 +2475,7 @@ bool isVariableChangedByFunctionCall(const Token *tok, int indirect, const Setti
     }
 
     if (const Variable* var = tok->variable()) {
-        if (tok == var->nameToken() && (!var->isReference() || var->isConst()) && (var->isStlType() || !var->isClass())) // const ref or passed to (copy) ctor
+        if (tok == var->nameToken() && (!var->isReference() || var->isConst()) && (!var->isClass() || (var->valueType() && var->valueType()->container))) // const ref or passed to (copy) ctor
             return false;
     }
 

test/cfg/qt.cpp

@@ -437,6 +437,7 @@ void MacroTest3()
     QVERIFY2(2 >= 0, message.constData());
 }
 
+// cppcheck-suppress constParameterReference
 void validCode(int * pIntPtr, QString & qstrArg, double d)
 {
     Q_UNUSED(d)

test/cfg/std.cpp

@@ -38,6 +38,7 @@
 #include <iterator>
 #include <map>
 #include <memory>
+#include <mutex>
 #include <numeric>
 #include <queue>
 #include <set>
@@ -4923,3 +4924,8 @@ std::string global_scope_std() // #12355
     ::std::stringstream ss;
     return ss.str();
 }
+
+void unique_lock_const_ref(std::mutex& m)
+{
+    std::unique_lock lock(m);
+}