Fix #12992 (Refactoring: Use l-value reference specifier for assignment operators to prevent misuse) (#6665)

Author: danmar

cppcheckpremium-suppressions

@@ -10,6 +10,8 @@ normalCheckLevelMaxBranches
 # Cert C++
 ###########################################################################################################################
 
+# False positives for (a?b:c)&=true;
+premium-cert-exp35-c
 # False positives for initializations
 premium-cert-exp45-c
 # False positives when casting to uintptr
@@ -68,7 +70,6 @@ premium-misra-cpp-2023-13.1.2
 premium-misra-cpp-2023-13.3.1
 premium-misra-cpp-2023-13.3.2
 premium-misra-cpp-2023-13.3.3
-premium-misra-cpp-2023-15.0.2
 premium-misra-cpp-2023-15.1.2
 premium-misra-cpp-2023-15.1.3
 premium-misra-cpp-2023-18.1.1

lib/analyzer.h

@@ -36,7 +36,7 @@ struct Analyzer {
 
         Action() = default;
         Action(const Action&) = default;
-        Action& operator=(const Action& rhs) = default;
+        Action& operator=(const Action& rhs) & = default;
 
         template<class T,
                  REQUIRES("T must be convertible to unsigned int", std::is_convertible<T, unsigned int> ),

lib/importproject.h

@@ -74,7 +74,7 @@ class CPPCHECKLIB WARN_UNUSED ImportProject {
     ImportProject() = default;
     virtual ~ImportProject() = default;
     ImportProject(const ImportProject&) = default;
-    ImportProject& operator=(const ImportProject&) = default;
+    ImportProject& operator=(const ImportProject&) & = default;
 
     void selectOneVsConfig(Platform::Type platform);
     void selectVsConfigurations(Platform::Type platform, const std::vector<std::string> &configurations);

lib/library.cpp

@@ -153,7 +153,7 @@ Library::Library(const Library& other)
     : mData(new LibraryData(*other.mData))
 {}
 
-Library& Library::operator=(const Library& other)
+Library& Library::operator=(const Library& other) &
 {
     mData.reset(new LibraryData(*other.mData));
     return *this;

lib/library.h

@@ -57,7 +57,7 @@ class CPPCHECKLIB Library {
     ~Library();
 
     Library(const Library& other);
-    Library& operator=(const Library& other);
+    Library& operator=(const Library& other) &;
 
     enum class ErrorCode : std::uint8_t {
         OK,

lib/symboldatabase.cpp

@@ -2252,7 +2252,7 @@ Variable::~Variable()
     delete mValueType;
 }
 
-Variable& Variable::operator=(const Variable &var)
+Variable& Variable::operator=(const Variable &var) &
 {
     if (this == &var)
         return *this;

lib/symboldatabase.h

@@ -236,7 +236,7 @@ class CPPCHECKLIB Variable {
 
     ~Variable();
 
-    Variable &operator=(const Variable &var);
+    Variable &operator=(const Variable &var) &;
 
     /**
      * Get name token.

lib/valueptr.h

@@ -81,7 +81,7 @@ class CPPCHECKLIB ValuePtr {
         swap(mClone, rhs.mClone);
     }
 
-    ValuePtr<T>& operator=(ValuePtr rhs) {
+    ValuePtr<T>& operator=(ValuePtr rhs) & {
         swap(rhs);
         return *this;
     }