refs #13245 - use builddir consistently and verify usage of cached results in selfcheck

Author: firewave

.github/workflows/CI-unixish.yml

@@ -695,4 +695,10 @@ jobs:
 
       - name: Self check
         run: |
-          ./selfcheck.sh
+          mkdir b1
+          ./selfcheck.sh --cppcheck-build-dir=b1
+          discards=$(./selfcheck.sh "--debug-analyzerinfo --cppcheck-build-dir=b1 --showtime=none" 2>&1 | grep -v skipping)
+          if [ -n "$discards" ]; then
+            echo $discards
+            exit 1
+          fi

selfcheck.sh

@@ -9,9 +9,6 @@ if [ -n "$1" ]; then
   selfcheck_options="$selfcheck_options $1"
 fi
 
-mkdir_cmd=$(command -v mkdir)
-rm_cmd=$(command -v rm)
-
 # clear PATH to prevent unintentional process invocations
 export PATH=
 
@@ -20,20 +17,15 @@ ec=0
 # self check externals
 ./cppcheck $selfcheck_options externals || ec=1
 # self check lib/cli
-$mkdir_cmd b1
-./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options frontend || ec=1
-./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options -Ifrontend cli || ec=1
-./cppcheck $selfcheck_options $cppcheck_options --cppcheck-build-dir=b1 $naming_options --enable=internal lib || ec=1
+./cppcheck $selfcheck_options $cppcheck_options $naming_options frontend || ec=1
+./cppcheck $selfcheck_options $cppcheck_options $naming_options -Ifrontend cli || ec=1
+./cppcheck $selfcheck_options $cppcheck_options $naming_options --enable=internal lib || ec=1
 # check gui with qt settings
-$mkdir_cmd b2
-./cppcheck $selfcheck_options $cppcheck_options $gui_options --cppcheck-build-dir=b2 $naming_options -Icmake.output/gui -Ifrontend -Igui gui/*.cpp cmake.output/gui || ec=1
+./cppcheck $selfcheck_options $cppcheck_options $gui_options $naming_options -Icmake.output/gui -Ifrontend -Igui gui/*.cpp cmake.output/gui || ec=1
 # self check test and tools
 ./cppcheck $selfcheck_options $cppcheck_options -Ifrontend -Icli test/*.cpp || ec=1
 ./cppcheck $selfcheck_options $cppcheck_options -Icli tools/dmake/*.cpp || ec=1
 # triage
 ./cppcheck $selfcheck_options $cppcheck_options $gui_options -Icmake.output/tools/triage -Igui tools/triage/*.cpp cmake.output/tools/triage || ec=1
 
-$rm_cmd -rf b2
-$rm_cmd -rf b1
-
 exit $ec