removed deprecated platform type Unspecified (#5903)

Author: firewave

cli/cmdlineparser.cpp

@@ -944,11 +944,6 @@ CmdLineParser::Result CmdLineParser::parseFromArgs(int argc, const char* const a
 
                     // keep existing platform from command-line intact
                     if (!platform.empty()) {
-                        if (platform == "Unspecified") {
-                            mLogger.printMessage("'Unspecified' is a deprecated platform type and will be removed in Cppcheck 2.14. Please use 'unspecified' instead.");
-                            platform = "unspecified";
-                        }
-
                         std::string errstr;
                         const std::vector<std::string> paths = {projectFile, argv[0]};
                         if (!mSettings.platform.set(platform, errstr, paths)) {

releasenotes.txt

@@ -21,3 +21,4 @@ Other:
 - The minimum required CMake version has been bumped to 3.5
 - Using Visual Studio with CMake now checks if the CMake version is at least 3.13. This was always required but was not checked explicitly.
 - Added '--template=simple'. It is expands to '{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]' without any additional location details.
+- Removed deprecated platform type 'Unspecified'. Please use 'unspecified' instead.

test/cli/more-projects_test.py

@@ -106,8 +106,8 @@ def test_project_unspecified_platform(tmpdir):
         f.write("int x;")
 
     ret, stdout, stderr = cppcheck(['--project=' + project_file, '--template=cppcheck1', '-q'])
-    assert ret == 0, stdout
-    assert stdout == "cppcheck: 'Unspecified' is a deprecated platform type and will be removed in Cppcheck 2.14. Please use 'unspecified' instead.\n"
+    assert ret == 1, stdout
+    assert stdout == "cppcheck: error: unrecognized platform: 'Unspecified'.\n"
     assert stderr == ''