Cleaning code (_field)

Author: csbernath

DataCommander.Providers.SqlServer/SqlServerProvider.cs

@@ -404,7 +404,7 @@ GetCompletionResponse IProvider.GetCompletion(
             {
                 var parts = new IdentifierParser(new StringReader(currentToken.Value)).Parse().ToList();
                 var lastPart = parts.Count > 0
-                    ? IListExtensions.Last(parts)
+                    ? ListExtensions.Last(parts)
                     : null;
                 var lastPartLength = lastPart != null
                     ? lastPart.Length
@@ -923,7 +923,7 @@ List<Statement> IProvider.GetStatements(string commandText)
             foreach (var statementTokens in tokens.Split(token => IsBatchSeparator(commandText, token)).Where(statementTokens => statementTokens.Length > 0))
             {
                 var startIndex = statementTokens[0].StartPosition;
-                var endIndex = IListExtensions.Last(statementTokens).EndPosition;
+                var endIndex = ListExtensions.Last(statementTokens).EndPosition;
                 var length = endIndex - startIndex + 1;
                 var statement = new Statement
                 {

Foundation.NetStandard-2.0/ArgumentEqualsSelection.cs

@@ -9,16 +9,16 @@ namespace Foundation
     /// <typeparam name="TArgument"></typeparam>
     public sealed class ArgumentEqualsSelection<TArgument> where TArgument : IEquatable<TArgument>
     {
-        private readonly TArgument argument;
-        private bool selected;
+        private readonly TArgument _argument;
+        private bool _selected;
 
         /// <summary>
         /// 
         /// </summary>
         /// <param name="argument"></param>
         public ArgumentEqualsSelection(TArgument argument)
         {
-            this.argument = argument;
+            this._argument = argument;
         }
 
         /// <summary>
@@ -31,10 +31,10 @@ public ArgumentEqualsSelection<TArgument> IfArgumentEquals(TArgument other, Acti
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
             {
-                selected = argument.Equals(other);
-                if (selected)
+                _selected = _argument.Equals(other);
+                if (_selected)
                 {
                     action();
                 }
@@ -51,7 +51,7 @@ public void Else(Action action)
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
                 action();
         }
     }

Foundation.NetStandard-2.0/ArgumentIsSelection.cs

@@ -9,16 +9,16 @@ namespace Foundation
     /// <typeparam name="TArgument"></typeparam>
     public sealed class ArgumentIsSelection<TArgument> where TArgument : class
     {
-        private readonly TArgument argument;
-        private bool selected;
+        private readonly TArgument _argument;
+        private bool _selected;
 
         /// <summary>
         /// 
         /// </summary>
         /// <param name="argument"></param>
         public ArgumentIsSelection(TArgument argument)
         {
-            this.argument = argument;
+            this._argument = argument;
         }
 
         /// <summary>
@@ -31,11 +31,11 @@ public ArgumentIsSelection<TArgument> IfArgumentIs<TArgumentAs>(Action<TArgument
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
             {
-                var argumentAs = argument as TArgumentAs;
-                selected = argumentAs != null;
-                if (selected)
+                var argumentAs = _argument as TArgumentAs;
+                _selected = argumentAs != null;
+                if (_selected)
                 {
                     action(argumentAs);
                 }
@@ -53,10 +53,10 @@ public ArgumentIsSelection<TArgument> IfArgumentIsNull(Action action)
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
             {
-                selected = argument == null;
-                if (selected)
+                _selected = _argument == null;
+                if (_selected)
                 {
                     action();
                 }
@@ -75,10 +75,10 @@ public ArgumentIsSelection<TArgument> If(Func<bool> condition, Action action)
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
             {
-                selected = condition();
-                if (selected)
+                _selected = condition();
+                if (_selected)
                 {
                     action();
                 }
@@ -95,7 +95,7 @@ public void Else(Action action)
         {
             Assert.IsNotNull(action);
 
-            if (!selected)
+            if (!_selected)
                 action();
         }
     }

Foundation.NetStandard-2.0/CommandLine.cs

@@ -13,7 +13,7 @@ namespace Foundation
     /// </summary>
     public sealed class CommandLine
     {
-        private readonly IndexableCollection<CommandLineArgument> arguments;
+        private readonly IndexableCollection<CommandLineArgument> _arguments;
 
         /// <summary>
         /// 
@@ -23,17 +23,17 @@ public CommandLine(string commandLine)
         {
             Assert.IsNotNull(commandLine);
 
-            this.arguments = new IndexableCollection<CommandLineArgument>(ListIndex);
+            this._arguments = new IndexableCollection<CommandLineArgument>(ListIndex);
             var dictionary = new Dictionary<string, ICollection<CommandLineArgument>>(StringComparer.InvariantCultureIgnoreCase);
             NameIndex = new NonUniqueIndex<string, CommandLineArgument>(
                 "nameIndex",
                 argument => GetKeyResponse.Create(argument.Name != null, argument.Name),
                 dictionary,
                 () => new List<CommandLineArgument>());
-            this.arguments.Indexes.Add(NameIndex);
+            this._arguments.Indexes.Add(NameIndex);
             var stringReader = new StringReader(commandLine);
             var arguments = Parse(stringReader);
-            this.arguments.Add(arguments);
+            this._arguments.Add(arguments);
         }
 
         /// <summary>

Foundation.NetStandard-2.0/CurrentDirectoryChanger.cs

@@ -7,23 +7,23 @@ namespace Foundation
     /// </summary>
     public sealed class CurrentDirectoryChanger : IDisposable
     {
-        private readonly string currentDirectory;
+        private readonly string _currentDirectory;
 
         /// <summary>
         /// 
         /// </summary>
         /// <param name="path"></param>
         public CurrentDirectoryChanger( string path )
         {
-            currentDirectory = Environment.CurrentDirectory;
+            _currentDirectory = Environment.CurrentDirectory;
             Environment.CurrentDirectory = path;
         }
 
         #region IDisposable Members
 
         void IDisposable.Dispose()
         {
-            Environment.CurrentDirectory = currentDirectory;
+            Environment.CurrentDirectory = _currentDirectory;
         }
 
         #endregion

Foundation.NetStandard-2.0/Data/ExecuteNonReaderRequest.cs

@@ -15,9 +15,13 @@ public ExecuteNonReaderRequest(CreateCommandRequest createCommandRequest, Cancel
         }
 
         public ExecuteNonReaderRequest(string commandText)
-            : this(new CreateCommandRequest(commandText), CancellationToken.None) => ;
+            : this(new CreateCommandRequest(commandText), CancellationToken.None)
+        {
+        }
 
         public ExecuteNonReaderRequest(string commandText, ReadOnlyCollection<object> parameters)
-            : this(new CreateCommandRequest(commandText, parameters), CancellationToken.None) => ;
+            : this(new CreateCommandRequest(commandText, parameters), CancellationToken.None)
+        {
+        }
     }
 }

Foundation.NetStandard-2.0/Data/IDataParameterCollectionExtensions.cs

@@ -11,7 +11,7 @@ namespace Foundation.Data
     /// <summary>
     ///
     /// </summary>
-    public static class IDataParameterCollectionExtensions
+    public static class DataParameterCollectionExtensions
     {
         /// <summary>
         /// 

Foundation.NetStandard-2.0/Data/IDataReaderExtensions.cs

@@ -7,7 +7,7 @@
 
 namespace Foundation.Data
 {
-    public static class IDataReaderExtensions
+    public static class DataReaderExtensions
     {
         public static void ReadResult(this IDataReader dataReader, Action readRecord)
         {

Foundation.NetStandard-2.0/Data/IDataRecordExtensions.cs

@@ -7,7 +7,7 @@ namespace Foundation.Data
     /// <summary>
     /// 
     /// </summary>
-    public static class IDataRecordExtensions
+    public static class DataRecordExtensions
     {
         public static byte[] GetBytes(this IDataRecord dataRecord, int fieldIndex)
         {

Foundation.NetStandard-2.0/Data/IDbCommandAsyncExecutorExtensions.cs

@@ -7,7 +7,7 @@
 
 namespace Foundation.Data
 {
-    public static class IDbCommandAsyncExecutorExtensions
+    public static class DbCommandAsyncExecutorExtensions
     {
         private static Task ExecuteAsync(this IDbCommandAsyncExecutor executor, IEnumerable<ExecuteCommandAsyncRequest> requests, CancellationToken cancellationToken)
         {