From 1141438d4bb9a2c2af70af416e60f77f5bb6a4b2 Mon Sep 17 00:00:00 2001 From: Andrey Yamanov Date: Wed, 29 Jul 2026 15:24:24 +0200 Subject: [PATCH] ci: report Build & canary release once, and skip the canary on release PRs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two leftovers in the release config, both surfaced now that the Version Packages PR actually runs the required workflows. `Build & canary release` was reported twice under the same context name: a three-second no-op in pull-request.yml and the real build in publish.yml. Branch protection could therefore be satisfied by whichever reported first, including the no-op that builds nothing. Remove the no-op; the real job in publish.yml carries the name. Both workflows share the same `paths-ignore`, so which PRs get the check is unchanged. The canary publish also ran on the Version Packages PR, whose diff is only a version bump and changelog — so it published a duplicate of what main had just released and left another stale `pr_*` dist-tag behind. Guard the publish and PR-comment steps on the release branch. The job still runs, so the required check reports and the build still verifies the exact tree about to ship. Co-Authored-By: Claude Opus 5 --- .changeset/tidy-release-checks.md | 5 +++++ .github/workflows/publish.yml | 7 +++++++ .github/workflows/pull-request.yml | 9 --------- 3 files changed, 12 insertions(+), 9 deletions(-) create mode 100644 .changeset/tidy-release-checks.md diff --git a/.changeset/tidy-release-checks.md b/.changeset/tidy-release-checks.md new file mode 100644 index 000000000..c44ce4342 --- /dev/null +++ b/.changeset/tidy-release-checks.md @@ -0,0 +1,5 @@ +--- +'@cube-dev/ui-kit': patch +--- + +Release-pipeline maintenance, no runtime changes: the `Build & canary release` check is no longer reported twice by two different workflows, and the Version Packages PR no longer publishes a redundant canary or leaves a stale `pr_*` dist-tag behind. diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 92199f81d..156994755 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -81,7 +81,13 @@ jobs: - name: Clear .npmrc auth token (use OIDC instead) run: npm config delete //registry.npmjs.org/:_authToken || true + # The Version Packages PR changes nothing but the version and changelog, + # so a canary of it would be a duplicate of what `main` already published + # and would leave another stale `pr_*` dist-tag behind. The job itself + # still runs so the required `Build & canary release` check reports, and + # the build above still verifies the exact tree that is about to ship. - name: Publish canary to npm + if: github.head_ref != 'changeset-release/main' env: CANARY_VERSION: ${{ steps.version.outputs.version }} PR_TAG: pr_${{ github.event.number }} @@ -94,6 +100,7 @@ jobs: fi - name: Comment PR + if: github.head_ref != 'changeset-release/main' uses: actions/github-script@v6 with: github-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index c8ec0107a..9c269bcd5 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -18,15 +18,6 @@ permissions: # Note: Canary publishing is handled by publish.yml workflow jobs: - # This job exists only to satisfy branch protection rules that expect this check name - # The actual publishing is done in publish.yml - build-canary-status: - name: 'Build & canary release' - runs-on: ubuntu-latest - steps: - - name: Publishing handled by publish.yml - run: echo "Canary publishing is handled by the Publish workflow (publish.yml)" - tests: name: 'Tests & lint' runs-on: ubuntu-latest