Skip to content

Commit 03b41fa

Browse files
committed
chore(ci): Enable unit and integration tests for node.js v24
1 parent 7d72978 commit 03b41fa

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/push.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ jobs:
8282
strategy:
8383
matrix:
8484
# Current docker version + next LTS
85-
# TODO: Add 24 after it's been released
86-
node-version: [22.x]
85+
node-version: [22.x, 24.x]
8786
# Don't forget to update build-native-release
8887
python-version: [3.11]
8988
fail-fast: false
@@ -416,7 +415,7 @@ jobs:
416415

417416
strategy:
418417
matrix:
419-
node-version: [22.x]
418+
node-version: [22.x, 24.x]
420419
# Vertica tests are disabled because around 20.08.2025 someone
421420
# totally removed all vertica-ce docker repository from dockerhub.
422421
# @see https://github.com/vertica/vertica-containers/issues/64
@@ -520,13 +519,16 @@ jobs:
520519
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_USER: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_USER }}
521520
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_PASS: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_PASS }}
522521
- name: Fix lcov paths
522+
if: (matrix.node-version == '24.x')
523523
run: |
524524
./.github/actions/codecov-fix.sh
525525
- name: Combine all fixed LCOV files
526+
if: (matrix.node-version == '24.x')
526527
run: |
527528
echo "" > ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov
528529
find ./packages -type f -name lcov.fixed.info -exec cat {} + >> ./combined-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}.lcov || true
529530
- name: Upload coverage artifact
531+
if: (matrix.node-version == '24.x')
530532
uses: actions/upload-artifact@v4
531533
with:
532534
name: coverage-integration-${{ matrix.db }}-${{ matrix.use_tesseract_sql_planner }}

0 commit comments

Comments
 (0)