-
Notifications
You must be signed in to change notification settings - Fork 197
Open
Labels
Description
Issue
The Add-AccountDependency function in Onboard-DependentAccountsFromCSV.ps1 contains several bugs that prevent proper execution:
What's fixed
- Missing parameter separator (line 523): Space missing between
-Headerparameter value and-Commandparameter - Property name typos (lines 544, 546):
useNameshould beuserNamewhen accessing account details - Missing property accessor (line 737): Missing
.idsuffix when assigning Master Account ID from Find-MasterAccount function
Changes
See diff below for exact corrections.
Impact
- Prevents script from correctly retrieving account details
- Fixes account dependency validation logic
- Allows proper Master Account ID assignment
diff --git a/Dependent Account onboard utility/Onboard-DependentAccountsFromCSV.ps1 b/Dependent Account onboard utility/Onboard-DependentAccountsFromCSV.ps1
index 99e2614..2660174 100644
--- a/Dependent Account onboard utility/Onboard-DependentAccountsFromCSV.ps1
+++ b/Dependent Account onboard utility/Onboard-DependentAccountsFromCSV.ps1
@@ -520,7 +520,7 @@ Function Add-AccountDependency
$retResult = $false
if($null -ne $MasterID)
{
- $accountDetails = $(Invoke-Rest -Uri ($URL_AccountsDetails -f $MasterID) -Header $global:g_LogonHeader-Command "GET")
+ $accountDetails = $(Invoke-Rest -Uri ($URL_AccountsDetails -f $MasterID) -Header $global:g_LogonHeader -Command "GET")
}
$addDiscoveredAccountBody = @{
"userName"=$dependencyObject.userName;
@@ -541,9 +541,9 @@ Function Add-AccountDependency
If($null -ne $accountDetails)
{
# Verify details and complete missing ones
- if($accountDetails.useName -ne $dependencyObject.userName)
+ if($accountDetails.userName -ne $dependencyObject.userName)
{
- $addDiscoveredAccountBody.userName = $accountDetails.useName
+ $addDiscoveredAccountBody.userName = $accountDetails.userName
}
if($accountDetails.address -ne $dependencyObject.address)
{
@@ -734,7 +734,7 @@ catch {
# Search for Master Account
$foundMasterAccount = $null
try {
- $foundMasterAccount = (Find-MasterAccount -accountName $account.userName -accountAddress $account.address).id
+ $foundMasterAccount = (Find-MasterAccount -accountName $account.userName -accountAddress $account.address)
} catch {
Write-LogMessage -Type Error -Msg "Error searching for Master Account. Error: $(Join-ExceptionMessage $_.Exception)"
}
(END)Reactions are currently unavailable