From 417977a4b31310de85a070d1d60c4b787feb43eb Mon Sep 17 00:00:00 2001 From: Jan Rose Date: Fri, 12 Jun 2026 12:51:16 +0200 Subject: [PATCH 1/2] Remove redundant base_parameters from Vector Search example jobs Job-level parameters are automatically pushed down to notebook tasks and read via dbutils.widgets.get(), and job parameters take precedence over same-key task parameters anyway, so mirroring them through base_parameters had no effect. Follow-up to review feedback on #153. --- .../resources/query-job.yml | 9 ++------- .../resources/setup-job.yml | 8 ++------ 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/knowledge_base/vector_search_product_discovery/resources/query-job.yml b/knowledge_base/vector_search_product_discovery/resources/query-job.yml index 1f6e50d..69c9ea2 100644 --- a/knowledge_base/vector_search_product_discovery/resources/query-job.yml +++ b/knowledge_base/vector_search_product_discovery/resources/query-job.yml @@ -28,11 +28,6 @@ resources: - task_key: query environment_key: serverless_env notebook_task: + # Job parameters are pushed down to the notebook automatically; + # no base_parameters needed. notebook_path: ../src/02_query_demo.py - base_parameters: - index_name: "{{job.parameters.index_name}}" - endpoint_name: "{{job.parameters.endpoint_name}}" - embedding_model: "{{job.parameters.embedding_model}}" - embedding_dimension: "{{job.parameters.embedding_dimension}}" - query: "{{job.parameters.query}}" - num_results: "{{job.parameters.num_results}}" diff --git a/knowledge_base/vector_search_product_discovery/resources/setup-job.yml b/knowledge_base/vector_search_product_discovery/resources/setup-job.yml index f2e2873..39b76cf 100644 --- a/knowledge_base/vector_search_product_discovery/resources/setup-job.yml +++ b/knowledge_base/vector_search_product_discovery/resources/setup-job.yml @@ -27,12 +27,8 @@ resources: description: Load products from JSON, embed descriptions, and upsert into the Vector Search index environment_key: serverless_env notebook_task: + # Job parameters are pushed down to the notebook automatically; + # no base_parameters needed. notebook_path: ../src/01_upsert_products.py - base_parameters: - index_name: "{{job.parameters.index_name}}" - endpoint_name: "{{job.parameters.endpoint_name}}" - embedding_model: "{{job.parameters.embedding_model}}" - embedding_dimension: "{{job.parameters.embedding_dimension}}" - data_path: "{{job.parameters.data_path}}" max_concurrent_runs: 1 From 64e5afe88b7cd578fb0a44ae33d4a8684fd98800 Mon Sep 17 00:00:00 2001 From: Jan Rose Date: Fri, 12 Jun 2026 13:11:25 +0200 Subject: [PATCH 2/2] Drop explanatory comments --- .../vector_search_product_discovery/resources/query-job.yml | 2 -- .../vector_search_product_discovery/resources/setup-job.yml | 2 -- 2 files changed, 4 deletions(-) diff --git a/knowledge_base/vector_search_product_discovery/resources/query-job.yml b/knowledge_base/vector_search_product_discovery/resources/query-job.yml index 69c9ea2..6309b0e 100644 --- a/knowledge_base/vector_search_product_discovery/resources/query-job.yml +++ b/knowledge_base/vector_search_product_discovery/resources/query-job.yml @@ -28,6 +28,4 @@ resources: - task_key: query environment_key: serverless_env notebook_task: - # Job parameters are pushed down to the notebook automatically; - # no base_parameters needed. notebook_path: ../src/02_query_demo.py diff --git a/knowledge_base/vector_search_product_discovery/resources/setup-job.yml b/knowledge_base/vector_search_product_discovery/resources/setup-job.yml index 39b76cf..e636141 100644 --- a/knowledge_base/vector_search_product_discovery/resources/setup-job.yml +++ b/knowledge_base/vector_search_product_discovery/resources/setup-job.yml @@ -27,8 +27,6 @@ resources: description: Load products from JSON, embed descriptions, and upsert into the Vector Search index environment_key: serverless_env notebook_task: - # Job parameters are pushed down to the notebook automatically; - # no base_parameters needed. notebook_path: ../src/01_upsert_products.py max_concurrent_runs: 1