Skip to content

Commit ad93bad

Browse files
ci(kernel): install per-tier extras explicitly, not --all-extras
The "Unit Tests + PyArrow" job used --all-extras, which predates the [kernel] extra. Now that [kernel] exists, --all-extras silently also installs the kernel wheel — so that tier no longer isolated the "pyarrow present, kernel absent" configuration and overlapped the new "Unit Tests + Kernel" job. - Unit Tests + PyArrow: --extras pyarrow (pyarrow only; no kernel). - Unit Tests + Kernel: --extras kernel (resolves the published databricks-sql-kernel wheel via the [kernel] extra — the exact edge `pip install databricks-sql-connector[kernel]` uses — which transitively brings pyarrow). Each tier now targets its configuration precisely. The kernel install path here (published wheel via the extra) is intentionally distinct from kernel-e2e.yml, which maturin-builds tip-of-tree at KERNEL_REV. Verified against the proxy: --extras pyarrow installs pyarrow and NOT the kernel; --extras kernel installs databricks-sql-kernel 0.1.2. Co-authored-by: Isaac Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
1 parent 09d61af commit ad93bad

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/code-quality-checks.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,11 @@ jobs:
7777
uses: ./.github/actions/setup-poetry
7878
with:
7979
python-version: ${{ matrix.python-version }}
80-
install-args: "--all-extras"
80+
# Install ONLY the pyarrow extra (not --all-extras) so this
81+
# tier isolates the "pyarrow present, kernel absent"
82+
# configuration. --all-extras would also pull the kernel wheel,
83+
# making this job redundant with "Unit Tests + Kernel".
84+
install-args: "--extras pyarrow"
8185
cache-suffix: "pyarrow-${{ matrix.dependency-version }}-"
8286
- name: Install Python tools for custom versions
8387
if: matrix.dependency-version != 'default'
@@ -121,9 +125,11 @@ jobs:
121125
uses: ./.github/actions/setup-poetry
122126
with:
123127
python-version: ${{ matrix.python-version }}
124-
# --all-extras installs the [kernel] extra, pulling the
125-
# published databricks-sql-kernel wheel (+ its pyarrow).
126-
install-args: "--all-extras"
128+
# Install the kernel extra (pulls the published
129+
# databricks-sql-kernel wheel, which transitively brings
130+
# pyarrow). Explicit --extras kernel rather than --all-extras
131+
# so this tier targets the kernel configuration specifically.
132+
install-args: "--extras kernel"
127133
cache-suffix: "kernel-"
128134
- name: Show installed versions
129135
run: |

0 commit comments

Comments
 (0)