refactor: set pipelines and local node versions equally (#331)

mfranzke · web-flow · commit d22ea64ea129 · 2023-02-22T07:51:29.000+01:00
* refactor: set pipelines and local node equally

* refactor: moved node version setup to init cache

* refactor: removed the other unnecessary if condition

* fix: added missing property
diff --git a/.github/actions/npm-cache/action.yml b/.github/actions/npm-cache/action.yml
@@ -3,6 +3,19 @@ description: "Initialize NPM Cache"
 runs:
   using: "composite"
   steps:
+    - name: Setup Node version equally to our local development version
+      # pick the Node version to use and install it
+      # https://github.com/actions/setup-node
+      uses: actions/setup-node@v3
+      with:
+        node-version: 16
+
+    - name: Display node and npm version
+      shell: bash
+      run: |
+        node --version
+        npm --version
+
     - uses: actions/cache@v3
       id: "npm-cache" # use this to check for `cache-hit` ==> if: steps.npm-cache.outputs.cache-hit != 'true'
       with:
diff --git a/.github/workflows/00-init.yml b/.github/workflows/00-init.yml
@@ -14,20 +14,6 @@ jobs:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache Default
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/00-scan-secrets.yml b/.github/workflows/00-scan-secrets.yml
@@ -12,20 +12,6 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: ↔ Extract branch name
         uses: ./.github/actions/extract-branch
         id: extract_branch
diff --git a/.github/workflows/01-build.yml b/.github/workflows/01-build.yml
@@ -11,20 +11,6 @@ jobs:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/01-get-publish-version.yml b/.github/workflows/01-get-publish-version.yml
@@ -27,20 +27,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/01-lint.yml b/.github/workflows/01-lint.yml
@@ -11,20 +11,6 @@ jobs:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/01-test.yml b/.github/workflows/01-test.yml
@@ -11,20 +11,6 @@ jobs:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/02-deploy-gh-pages.yml b/.github/workflows/02-deploy-gh-pages.yml
@@ -23,20 +23,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/03-publish-packages.yml b/.github/workflows/03-publish-packages.yml
@@ -24,20 +24,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Init Cache
         uses: ./.github/actions/npm-cache
 
diff --git a/.github/workflows/99-add-url-comment.yml b/.github/workflows/99-add-url-comment.yml
@@ -11,20 +11,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 📡 Add comment
         uses: actions/github-script@v6
         with:
diff --git a/.github/workflows/99-auto-update-pr.yml b/.github/workflows/99-auto-update-pr.yml
@@ -22,20 +22,6 @@ jobs:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: ↔ Create Pull Request
         uses: actions/github-script@v6
         id: create-pr
diff --git a/.github/workflows/99-codeql-analysis.yml b/.github/workflows/99-codeql-analysis.yml
@@ -16,20 +16,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔄 Initialize CodeQL
         uses: github/codeql-action/init@v2
         with:
diff --git a/.github/workflows/99-dependency-review.yml b/.github/workflows/99-dependency-review.yml
@@ -10,19 +10,5 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 🔎 Dependency Review
         uses: actions/dependency-review-action@v3
diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml
@@ -13,20 +13,6 @@ jobs:
       - name: ⬇ Checkout repo
         uses: actions/checkout@v3
 
-      - name: Setup node equally to our local development version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        # pick the Node version to use and install it
-        # https://github.com/actions/setup-node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 16
-
-      - name: Display node and npm version
-        if: steps.npm-cache.outputs.cache-hit != 'true'
-        run: |
-          node --version
-          npm --version
-
       - name: 📥 Get gh-pages tar
         run: wget -q https://github.com/db-ui/core/tarball/gh-pages
 
