Skip to content

Commit 81a8fde

Browse files
authored
Update default.spec.ts
1 parent d7ffa48 commit 81a8fde

File tree

1 file changed

+23
-25
lines changed

1 file changed

+23
-25
lines changed

showcases/patternhub/tests/default.spec.ts

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const getDefaultScreenshotTest = async (
99
) => {
1010
test(`${type} should match screenshot`, async ({ page }) => {
1111
await page.goto(`${path}`, {
12-
waitUntil: 'domcontentloaded'
12+
waitUntil: 'networkidle'
1313
});
1414
await fn(page);
1515
await expect(page).toHaveScreenshot([name, 'patternhub.png']);
@@ -29,29 +29,27 @@ for (const group of Components) {
2929
}
3030
);
3131
});
32-
// COMMENTED OUT: This test fails because h1 elements are not consistently visible on all pages
33-
// test.describe(component.name, async () => {
34-
// await getDefaultScreenshotTest(
35-
// component.name,
36-
// `overview`,
37-
// `.${group.path}/${component.name}/overview?fullscreen=true`,
38-
// async (page) => {
39-
// const firstH2 = page.locator('h1').first();
40-
// await expect(firstH2).toBeVisible();
41-
// }
42-
// );
43-
// });
44-
// COMMENTED OUT: This test fails because h2 elements are not consistently visible on properties pages
45-
// test.describe(component.name, async () => {
46-
// await getDefaultScreenshotTest(
47-
// component.name,
48-
// `properties`,
49-
// `.${group.path}/${component.name}/properties?fullscreen=true&noh1=true`,
50-
// async (page) => {
51-
// const firstH2 = page.locator('h2').first();
52-
// await expect(firstH2).toBeVisible();
53-
// }
54-
// );
55-
// });
32+
test.describe(component.name, async () => {
33+
await getDefaultScreenshotTest(
34+
component.name,
35+
`overview`,
36+
`.${group.path}/${component.name}/overview?fullscreen=true`,
37+
async (page) => {
38+
const firstH2 = page.locator('h1').first();
39+
await expect(firstH2).toBeVisible();
40+
}
41+
);
42+
});
43+
test.describe(component.name, async () => {
44+
await getDefaultScreenshotTest(
45+
component.name,
46+
`properties`,
47+
`.${group.path}/${component.name}/properties?fullscreen=true&noh1=true`,
48+
async (page) => {
49+
const firstH2 = page.locator('h2').first();
50+
await expect(firstH2).toBeVisible();
51+
}
52+
);
53+
});
5654
}
5755
}

0 commit comments

Comments
 (0)