Skip to content

Commit 95c1224

Browse files
authored
fix: issue with dependencies for angular builds (#246)
* fix: issue with dependencies for angular builds
1 parent 2f184b5 commit 95c1224

File tree

4 files changed

+174
-130
lines changed

4 files changed

+174
-130
lines changed

.github/scripts/publish-npm.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,7 @@ do
2626

2727
if [[ $PACKAGE != 'foundations' ]]; then
2828
echo "🕵️‍ Set foundations dependency"
29-
if [[ $PACKAGE == 'ngx-components' ]]; then
30-
npm pkg set peerDependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
31-
else
32-
npm pkg set dependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
33-
fi
29+
npm pkg set dependencies.@db-ui/foundations="$VALID_SEMVER_VERSION" --workspace=@db-ui/"$PACKAGE"
3430
fi
3531

3632
echo "📦 Create npm package"

output/angular/ng-package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"lib": {
55
"entryFile": "src/index.ts"
66
},
7-
"assets": ["src/components/**/*.scss"]
7+
"assets": ["src/components/**/*.scss"],
8+
"allowedNonPeerDependencies": ["@db-ui/foundations"]
89
}

output/angular/package.json

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,28 +35,12 @@
3535
"module": "dist/fesm5.js",
3636
"main": "dist/fesm5.js",
3737
"types": "dist/core.d.ts",
38-
"peerDependencies": {
39-
"@db-ui/foundations": "*",
40-
"@angular/animations": "~14.2.12",
41-
"@angular/common": "~14.2.12",
42-
"@angular/compiler": "~14.2.12",
43-
"@angular/core": "~14.2.12",
44-
"@angular/forms": "~14.2.12",
45-
"@angular/platform-browser": "~14.2.12",
46-
"@angular/platform-browser-dynamic": "~14.2.12",
47-
"rxjs": "~7.4.0",
48-
"tslib": "^2.4.1",
49-
"zone.js": "~0.11.4"
38+
"dependencies": {
39+
"@db-ui/foundations": "*"
5040
},
5141
"devDependencies": {
5242
"@angular-devkit/build-angular": "~14.2.10",
53-
"@angular/cli": "~14.2.10",
54-
"@angular/compiler-cli": "~14.2.12",
55-
"@types/estree": "^1.0.0",
56-
"@types/node": "^18.11.18",
57-
"ng-packagr": "14.2.2",
58-
"schematics-scss-migrate": "^1.3.15",
59-
"typescript": "~4.8.4"
43+
"ng-packagr": "14.2.2"
6044
},
6145
"files": [
6246
"dist/"

0 commit comments

Comments
 (0)