`Download All Library` feature in Storage Settings doesn't work

[josh-sukheja]

Bug Description

Not sure what I'm missing for this to work. Whenever I tap the Download All Library button in the Storage Settings, I get the same toast "No songs available. Please load your library first.".

Steps to Reproduce

1. Install the app.
2. Connect to my local Navidrome (v0.60.3) server. Connection via valid https URL (works in browsers).
   • My Navidrome server has only one music library with all songs inside.
3. See my music populated. I can stream music and download individual songs/albums with no problem.
4. Open the Storage Settings from the Library page. Tap the Download All Library button. See the issue.

Expected Behavior

I'd expect this button to start download every song in the library on my connected Navidrome server.

App Version

1.0.8

Subsonic Server

Navidrome v0.60.3

Relevant Logs

[rshackleton]

For what it is worth, I used this feature on 1.0.8 yesterday without issue so this isn't a consistent bug.

[rshackleton]

Just experienced this myself after reinstalling the app. A workaround is:

1. Setup the connection to your server
2. Navigate to the "All Songs" page and allow that to load
3. Navigate to "Settings => Storage" and download library should now work

The issue is that the download button relies on libraryProvider.cachedAllSongs which isn't populated.

Musly/lib/screens/settings_storage_tab.dart

Line 422 in 4e99337

final allSongs = libraryProvider.cachedAllSongs;

Visiting the "All Songs" screen forces the library provider to set _cachedAllSongs and therefore allows the download all library button to work.

I think we can fix this by calling await libraryProvider.ensureLibraryLoaded(); when the download button is pressed, similar to how it is called here.

Musly/lib/screens/all_songs_screen.dart

Line 55 in 4e99337

await libraryProvider.ensureLibraryLoaded();

[josh-sukheja]

Yep, can confirm that workaround fixed it. I would never have guessed this. Thanks for looking into it.