test(rules-doc): close both /code-review findings

The exactly-one-pointer guard added two commits ago claimed more
than it enforced. Its docstring said a shipped rule "cannot keep a
stale tracking pointer once its issues close", but the test reads
the doc only and cannot see code. Meanwhile
test_implemented_matches_citing_modules skipped any rule without
implemented:, so a rule that gained code and a citation while
keeping tracked: passed both. That is exactly the state the
docstring called unrepresentable.

The citations test now handles the tracked: branch, and the
docstring states its own scope instead of the pair's: neither test
alone makes a stale pointer unrepresentable, the pair does.
Mutation-tested on the finding's own scenario -- adding a P6
citation to _post_rules.py while leaving tracked: in place now
fails with the swap instruction, and the restore was verified by
diff.

The DEVIATION note on P1 wrote its example values in double quotes,
which put four extra quoted spans inside the citation block that
test_citations_are_verbatim_excerpts parses -- it passed only
because the check takes the FIRST span. Moving the note above the
citation line, a natural edit, would have made the excerpt resolve
to "de Mesnil Juan" and failed against prose that is entirely
correct. Values are unquoted now, and the note says why so the next
editor does not helpfully re-add them.

Considered and rejected: asserting exactly one quoted span per
citation block, which would be the unrepresentable-states fix.
Measured first -- 38 blocks carry one, but _group.py's M1 block
legitimately carries six, so the invariant does not hold today and
imposing it would mean rewriting an unrelated comment.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: derek73

nameparser/_pipeline/_post_rules.py

@@ -99,10 +99,14 @@ def post_rules(state: ParseState) -> ParseState:
     # attaches to are the family, and any name words beyond that
     # read by position." (v1 handle_non_first_name_prefix; history:
     # decisions.md#P1)
-    # DEVIATION #364: the fold below still takes every remaining
-    # name word, not just the particle's own; "de Mesnil Juan" gives
-    # family="de Mesnil Juan" where the rule says family="de Mesnil"
-    # plus given="Juan". Pinned by the deviates: markers on P1.
+    # DEVIATION #364: the fold below still takes every remaining name
+    # word, not just the particle run's own -- de Mesnil Juan gives
+    # family=de Mesnil Juan where the rule says family=de Mesnil plus
+    # given=Juan. Pinned by the deviates: markers on P1.
+    # Values written unquoted deliberately: this note sits INSIDE the
+    # citation block above (# decisions.md#P1) does not close it --
+    # _CITE_RE wants a colon after the ID), and the excerpt check
+    # takes the first quoted span in the block.
     # Code-local: a lone PIECE is the test at both sites, so a
     # particle group already chained forward is not a lone particle,
     # and rule H1 above cannot be what produces the fold's family

tests/v2/test_doc_citations.py

@@ -102,13 +102,23 @@ def test_implemented_matches_citing_modules() -> None:
         citing.setdefault(cid, set()).add(str(path.relative_to(REPO)))
     problems = []
     for rule in parse_rules_doc(RULES_DOC.read_text(encoding="utf-8")):
+        actual = citing.get(rule.rule_id, set())
         if rule.implemented:
-            actual = citing.get(rule.rule_id, set())
             declared = set(rule.implemented)
             if actual != declared:
                 problems.append(
                     f"{rule.rule_id}: implemented: says {sorted(declared)} "
                     f"but citations found in {sorted(actual)}")
+        elif rule.tracked and actual:
+            # The other half of test_rules_doc.py's exactly-one-pointer
+            # rule: that test cannot see code, so a rule that SHIPPED
+            # while keeping tracked: would pass it. Without this branch
+            # the stale pointer is invisible -- the loop above skips
+            # any rule with no implemented: at all.
+            problems.append(
+                f"{rule.rule_id}: declares tracked: {sorted(rule.tracked)} "
+                f"but code cites it in {sorted(actual)}; swap tracked: for "
+                f"implemented: now that something implements it")
     assert not problems, "\n".join(problems)
 
 

tests/v2/test_rules_doc.py

@@ -37,8 +37,15 @@ def test_every_rule_has_examples_and_boundary(rule: Rule) -> None:
 def test_every_rule_points_at_code_or_at_the_work(rule: Rule) -> None:
     """A normative rule names the code honoring it, or the issues that
     would ship it -- never neither, so an unimplemented rule cannot sit
-    in the doc untracked, and never both, so a shipped rule cannot keep
-    a stale tracking pointer once its issues close."""
+    in the doc untracked, and never both.
+
+    Scope, precisely: this test reads the DOC only, so it cannot tell
+    that a tracked: rule has since been implemented -- adding the code
+    and its citation while leaving tracked: in place passes here. That
+    half is test_doc_citations.py::test_implemented_matches_citing_
+    modules, which sees the citing modules. Neither test alone makes a
+    stale pointer unrepresentable; the pair does.
+    """
     assert rule.implemented or rule.tracked, (
         f"{rule.rule_id}: add 'implemented: <path>' or, if nothing "
         f"implements it yet, 'tracked: #N' naming the issues that would")