fix(assets): limit the live watcher to one test and defer temp-dir cleanup

The first attempt (a 50ms post-close grace period) wasn't enough on
Windows CI runners — every one of the 13 tests in assets.test.ts was
opening, closing, and immediately deleting a live-watched temp dir,
each one a fresh chance at the libuv fs-event race.

- Only the test that actually exercises the watcher now passes
  watch: true; the other 12 opt out (watch: false), so this file
  opens exactly one native Windows directory watch per run.
- Every temp dir's deletion is deferred to a single afterAll instead
  of each test's afterEach, so cleanup runs well clear of that one
  watcher's teardown.
- Bumped the win32 post-close grace period from 50ms to 200ms.

Author: antfubot

plugins/assets/src/node/watcher.ts

@@ -34,14 +34,14 @@ export function watchAssetsDir(ctx: DevframeNodeContext, dir: string): () => Pro
     await watcher.close()
     // On Windows, closing a chokidar/fs.watch handle doesn't guarantee the
     // OS has fully retired the outstanding ReadDirectoryChangesW request —
-    // ftruncate/close returns before libuv's IOCP completion drains. If the
-    // watched directory is deleted immediately after (as every test's
-    // `afterEach` does), that stale completion can reach
+    // close() returns before libuv's IOCP completion drains. If the watched
+    // directory is deleted right after (as a caller tearing down a
+    // short-lived context typically does), that stale completion can reach
     // `uv__fs_event_process` after the fact and trip its directory-prefix
     // sanity check, hard-crashing the process with
     // `Assertion failed: !_wcsnicmp(filename, dir, dirlen)` in fs-event.c.
-    // A short grace period gives the pending I/O time to actually settle.
+    // A grace period gives the pending I/O time to actually settle first.
     if (process.platform === 'win32')
-      await new Promise(resolve => setTimeout(resolve, 50))
+      await new Promise(resolve => setTimeout(resolve, 200))
   }
 }

plugins/assets/test/assets.test.ts

@@ -2,7 +2,7 @@ import type { AssetsServer, TestClient } from './_utils'
 import { Buffer } from 'node:buffer'
 import fsp from 'node:fs/promises'
 import { join } from 'node:path'
-import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+import { afterAll, afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { bootClient, call, cleanupTempDir, createTempDir, startAssetsServer } from './_utils'
 
 // A minimal, valid 1x1 PNG.
@@ -36,31 +36,44 @@ describe('assets plugin', () => {
   let server: AssetsServer
   let client: TestClient
 
+  // Every managed temp dir this file creates, deleted once at the very end
+  // rather than per-test. On Windows, closing a live chokidar watcher
+  // doesn't guarantee libuv has retired the outstanding
+  // ReadDirectoryChangesW request — deleting the directory it watched right
+  // after close() can trip a native assertion and hard-crash the process
+  // (see `watchAssetsDir`'s disposer). Deferring every directory's removal
+  // well past its server's shutdown keeps that race out of this suite.
+  const tempDirs: string[] = []
+
   beforeEach(async () => {
     dir = await createTempDir()
+    tempDirs.push(dir)
   })
 
   afterEach(async () => {
     await server?.close()
-    await cleanupTempDir(dir)
+  })
+
+  afterAll(async () => {
+    await Promise.all(tempDirs.map(cleanupTempDir))
   })
 
   it('lists no assets in an empty directory', async () => {
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
     const list = await call(client, 'devframes:plugin:assets:list')
     expect(list).toEqual([])
   })
 
   it('reports write capabilities by default', async () => {
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
     const caps = await call(client, 'devframes:plugin:assets:capabilities')
     expect(caps).toEqual({ write: true, uploadExtensions: expect.any(Array) })
   })
 
   it('creates a folder and uploads a file into it via the streaming channel', async () => {
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     await call(client, 'devframes:plugin:assets:mkdir', { path: 'icons' })
@@ -73,7 +86,7 @@ describe('assets plugin', () => {
   })
 
   it('reads image dimensions for an uploaded image', async () => {
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
     await upload(client, 'logo.png', ONE_PIXEL_PNG)
 
@@ -83,7 +96,7 @@ describe('assets plugin', () => {
 
   it('reads text content for a text asset', async () => {
     await fsp.writeFile(join(dir, 'notes.txt'), 'hello world', 'utf-8')
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     const content = await call(client, 'devframes:plugin:assets:read-text', 'notes.txt')
@@ -93,7 +106,7 @@ describe('assets plugin', () => {
   it('renames an asset within its folder', async () => {
     await fsp.mkdir(join(dir, 'icons'), { recursive: true })
     await fsp.writeFile(join(dir, 'icons/old.txt'), 'x', 'utf-8')
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     const renamed = await call(client, 'devframes:plugin:assets:rename', { path: 'icons/old.txt', newName: 'new' })
@@ -105,7 +118,7 @@ describe('assets plugin', () => {
   it('rejects renaming onto an existing file', async () => {
     await fsp.writeFile(join(dir, 'a.txt'), 'a', 'utf-8')
     await fsp.writeFile(join(dir, 'b.txt'), 'b', 'utf-8')
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     await expect(call(client, 'devframes:plugin:assets:rename', { path: 'a.txt', newName: 'b' })).rejects.toThrow()
@@ -114,7 +127,7 @@ describe('assets plugin', () => {
   it('deletes one or more assets in a single call', async () => {
     await fsp.writeFile(join(dir, 'a.txt'), 'a', 'utf-8')
     await fsp.writeFile(join(dir, 'b.txt'), 'b', 'utf-8')
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     const result = await call(client, 'devframes:plugin:assets:delete', { paths: ['a.txt', 'b.txt', 'missing.txt'] })
@@ -123,7 +136,7 @@ describe('assets plugin', () => {
   })
 
   it('rejects paths that escape the managed directory', async () => {
-    server = await startAssetsServer(dir)
+    server = await startAssetsServer(dir, { watch: false })
     client = bootClient(server.port)
 
     await expect(call(client, 'devframes:plugin:assets:read-text', '../../etc/passwd')).resolves.toBeNull()
@@ -133,7 +146,7 @@ describe('assets plugin', () => {
   })
 
   it('rejects uploads with a disallowed extension', async () => {
-    server = await startAssetsServer(dir, { uploadExtensions: ['png'] })
+    server = await startAssetsServer(dir, { uploadExtensions: ['png'], watch: false })
     client = bootClient(server.port)
 
     await expect(
@@ -142,7 +155,7 @@ describe('assets plugin', () => {
   })
 
   it('does not register write actions when write is disabled', async () => {
-    server = await startAssetsServer(dir, { write: false })
+    server = await startAssetsServer(dir, { write: false, watch: false })
     client = bootClient(server.port)
 
     const caps = await call(client, 'devframes:plugin:assets:capabilities')
@@ -151,7 +164,7 @@ describe('assets plugin', () => {
   })
 
   it('still registers open-in-editor and reveal-in-folder when write is disabled', async () => {
-    server = await startAssetsServer(dir, { write: false })
+    server = await startAssetsServer(dir, { write: false, watch: false })
 
     // open-in-editor / reveal-in-folder launch external OS apps, so assert
     // they're *registered* on the server context rather than invoking them
@@ -163,6 +176,9 @@ describe('assets plugin', () => {
     expect(defs.has('devframes:plugin:assets:mkdir')).toBe(false)
   })
 
+  // The one test that needs the live watcher — every other test above opts
+  // out of it (`watch: false`) so this is the only native fs watch handle
+  // this file ever opens, close()s, and deletes the directory of.
   it('broadcasts a change event when a file is added on disk', async () => {
     server = await startAssetsServer(dir)
     client = bootClient(server.port)