Background
pom.xml pins the Spotless googleJavaFormat version to 1.17.0 (from the original scaffold). The workshop branches moved to 1.27.0, but main stayed on 1.17.0. Older google-java-format versions can format code differently from newer tooling (IDE plugins, other contributors), causing recurring Spotless check failures for contributors using newer formats.
Impact
- Contributors using IDE formatting based on newer google-java-format may see
mvn spotless:check fail with no code change of their own.
- CI
spotless:check and local formatting can disagree across versions, causing noise in PRs.
How to reproduce
- Run
mvn spotless:check on main — passes with 1.17.0.
- Apply google-java-format 1.27+ to a file (e.g. via an IDE plugin).
- Run
mvn spotless:check again — may now fail on formatting differences for that file.
Where the fix should land
Bump the googleJavaFormat version in pom.xml to a current release (e.g. 1.27.0, matching the workshop branches), run mvn spotless:apply, and commit any resulting formatting changes in the same PR so the tree stays green.
Files touched
pom.xml
- Any
.java files re-formatted by mvn spotless:apply
Acceptance criteria
Background
pom.xmlpins the SpotlessgoogleJavaFormatversion to1.17.0(from the original scaffold). The workshop branches moved to1.27.0, butmainstayed on1.17.0. Older google-java-format versions can format code differently from newer tooling (IDE plugins, other contributors), causing recurring Spotless check failures for contributors using newer formats.Impact
mvn spotless:checkfail with no code change of their own.spotless:checkand local formatting can disagree across versions, causing noise in PRs.How to reproduce
mvn spotless:checkonmain— passes with 1.17.0.mvn spotless:checkagain — may now fail on formatting differences for that file.Where the fix should land
Bump the
googleJavaFormatversion inpom.xmlto a current release (e.g.1.27.0, matching the workshop branches), runmvn spotless:apply, and commit any resulting formatting changes in the same PR so the tree stays green.Files touched
pom.xml.javafiles re-formatted bymvn spotless:applyAcceptance criteria
pom.xmlgoogleJavaFormat version is updated.mvn spotless:checkpasses on the whole codebase.code-qualityjob is green.