From 1b747196ac87afeebddc2a9dc09bfe6a90a971ef Mon Sep 17 00:00:00 2001 From: Absaar IT Date: Fri, 11 Sep 2026 06:11:24 +0400 Subject: [PATCH] fix: collapse identical branches in AppStoreApplicationVersionRepository.FindWithFilter All branches of the if/else-if construct executed the identical statement 'impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...)'. The query and queryParams are fully built beforehand, so the branching on ChartRepoId/RegistryId was dead code. Collapsed to a single call. Fixes #6030 --- .../repository/AppStoreApplicationVersionRepository.go | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pkg/appStore/discover/repository/AppStoreApplicationVersionRepository.go b/pkg/appStore/discover/repository/AppStoreApplicationVersionRepository.go index c68d67c1cf..50595b5b59 100644 --- a/pkg/appStore/discover/repository/AppStoreApplicationVersionRepository.go +++ b/pkg/appStore/discover/repository/AppStoreApplicationVersionRepository.go @@ -183,15 +183,7 @@ func (impl *AppStoreApplicationVersionRepositoryImpl) FindWithFilter(filter *app query = query + ";" var err error - if len(filter.ChartRepoId) > 0 && len(filter.RegistryId) > 0 { - _, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...) - } else if len(filter.RegistryId) > 0 { - _, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...) - } else if len(filter.ChartRepoId) > 0 { - _, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...) - } else { - _, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...) - } + _, err = impl.dbConnection.Query(&appStoreWithVersion, query, queryParams...) if err != nil { return nil, err }