-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Thanks for your awesome library!
See this typing at
Line 57 in d644eb2
| export default function shellEncode(...cmds: string | string[] | IShellOptions): string; |
At least
cmds shall be an array of arguments because of the preceded three dots, but changing to...cmds: (string | string[] | IShellOptions)[] only works at a few situations and need casting to IShellOptions explicitly by as.Suggestion:
For our circumstance, the quantity of arguments shall be 1-3: (string) (string, string[]) (string, string[], IShellOptions) (string, IShellOptions). Maybe https://www.typescriptlang.org/docs/handbook/2/functions.html#function-overloads will fit.
Metadata
Metadata
Assignees
Labels
No labels