From 5080fa5fb3cd75d9306d2c0c8435318d9d6fb237 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 27 Mar 2026 14:33:48 +0100 Subject: [PATCH 1/2] DEV: Temporarily add DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS support --- .github/workflows/discourse-plugin.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/discourse-plugin.yml b/.github/workflows/discourse-plugin.yml index 3878d1c..5777629 100644 --- a/.github/workflows/discourse-plugin.yml +++ b/.github/workflows/discourse-plugin.yml @@ -20,6 +20,10 @@ on: container: type: string required: false + DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS: + type: string + required: false + default: "1" secrets: ssh_private_key: description: "Optional SSH private key to be used when cloning additional plugin repos" @@ -397,6 +401,7 @@ jobs: if: matrix.build_type == 'system' || matrix.build_type == 'frontend' env: EMBER_ENV: development + DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS: ${{ inputs.DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS }} run: | if [ -f script/assemble_ember_build.rb ]; then script/assemble_ember_build.rb From 76d5691d91f53670e4c8d86da2d000e0448976e6 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 27 Mar 2026 14:43:42 +0100 Subject: [PATCH 2/2] different approach Co-authored-by: David Taylor --- .github/workflows/discourse-plugin.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/discourse-plugin.yml b/.github/workflows/discourse-plugin.yml index 5777629..09abfb8 100644 --- a/.github/workflows/discourse-plugin.yml +++ b/.github/workflows/discourse-plugin.yml @@ -20,10 +20,6 @@ on: container: type: string required: false - DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS: - type: string - required: false - default: "1" secrets: ssh_private_key: description: "Optional SSH private key to be used when cloning additional plugin repos" @@ -401,9 +397,9 @@ jobs: if: matrix.build_type == 'system' || matrix.build_type == 'frontend' env: EMBER_ENV: development - DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS: ${{ inputs.DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS }} run: | if [ -f script/assemble_ember_build.rb ]; then + export DISCOURSE_DOWNLOAD_PRE_BUILT_ASSETS=$(bin/rails runner 'puts(Discourse.has_needed_version?(Discourse::VERSION::STRING, "2026.3.0-latest") ? 1 : 0)') script/assemble_ember_build.rb else bin/ember-cli --build