Storage setup script will copy default pages upon start-up

[renat1sakenov]

Hello,

as to the following lines, the default pages (playground / wiki / welcome) will always be copied to the storage location upon start-up and will always reappear in the application.

docker/Dockerfile

Line 19 in 6b6abf2

RUN /bin/bash /build-setup.sh

docker/root/build-setup.sh

Lines 32 to 33 in 6b6abf2

	mv /var/www/html/data /var/www/html/data.core
	ln -s /storage/data /var/www/html/data

docker/root/dokuwiki-storagesetup.sh

Lines 7 to 8 in 6b6abf2

	mkdir -p /storage/data
	cp -r /var/www/html/data.core/. /storage/data # includes hidden files

My question is: Am I missing something here? Or is this intended? If not, I'd open a pull request to implement my suggestion:

If /storage/data does not exist or is empty or env var COPY_DATA_CORE is set: - run "cp -r /var/www/html/data.core/. /storage/data"
else, do nothing.

or would it be required to check the storage directory for an old installation and then copy the data.core as well?

What do you think?

Thanks

[splitbrain]

It is intentional, to ensure that the newest files (especially for the syntax.txt) are available in the wiki when upgrading the container.

What is the actual issue/usecase you're trying to solve here?

[renat1sakenov]

Hello @splitbrain,

currently I'm observing following behavior:

Start dokuwiki container (e.g. /usr/bin/docker run --name test-docs --expose 8080 --network overlay-network -v /var/lib/docker/volumes/test_dokuwiki:/storage dokuwiki/dokuwiki:2023-04-04a)

Access the service over the web browser - I see the default pages - wiki / playground and so on.

Add / edit pages / remove default pages and so on

Shutdown dokuwiki container

Start dokuwiki container

Access the service over the web browser - I see the default pages (in addition to my pages), despite having them removed / edited...

What I expected:

The actual dokuwiki content - the pages - do not change upon restart of the container. This includes re-adding the default pages.

This is the issue I want to solve here.

Please let me know if I'm still not clear enough here, or whether you consider that an issue in the first place.

Thanks