Fix CodeQL findings

Author: commonsensesoftware

src/AspNet/OData/src/Asp.Versioning.WebApi.OData.ApiExplorer/ApiExplorer/ODataApiExplorer.cs

@@ -34,6 +34,7 @@ namespace Asp.Versioning.ApiExplorer;
 public class ODataApiExplorer : VersionedApiExplorer
 {
     private static readonly Regex odataVariableRegex = new( $"{{\\*{ODataRouteConstants.ODataPath}}}", CultureInvariant | Compiled | IgnoreCase );
+    private readonly ODataApiExplorerOptions options;
     private IModelTypeBuilder? modelTypeBuilder;
 
     /// <summary>
@@ -49,13 +50,13 @@ public ODataApiExplorer( HttpConfiguration configuration )
     /// <param name="configuration">The current <see cref="HttpConfiguration">HTTP configuration</see>.</param>
     /// <param name="options">The associated <see cref="ODataApiExplorerOptions">API explorer options</see>.</param>
     public ODataApiExplorer( HttpConfiguration configuration, ODataApiExplorerOptions options )
-        : base( configuration, options ) => Options = options;
+        : base( configuration, options ) => this.options = options;
 
     /// <summary>
     /// Gets the options associated with the API explorer.
     /// </summary>
     /// <value>The <see cref="ODataApiExplorerOptions">API explorer options</see>.</value>
-    protected new virtual ODataApiExplorerOptions Options { get; }
+    protected new virtual ODataApiExplorerOptions Options => options;
 
     /// <summary>
     /// Gets the model type builder used by the API explorer.

src/AspNet/WebApi/src/Asp.Versioning.WebApi.ApiExplorer/ApiExplorer/VersionedApiExplorer.cs

@@ -29,6 +29,7 @@ public class VersionedApiExplorer : IApiExplorer
 {
     private static readonly Regex actionVariableRegex = new( $"{{{RouteValueKeys.Action}}}", Compiled | IgnoreCase | CultureInvariant );
     private static readonly Regex controllerVariableRegex = new( $"{{{RouteValueKeys.Controller}}}", Compiled | IgnoreCase | CultureInvariant );
+    private readonly ApiExplorerOptions options;
     private readonly Lazy<ApiDescriptionGroupCollection> apiDescriptions;
     private IDocumentationProvider? documentationProvider;
     private ISunsetPolicyManager? sunsetPolicyManager;
@@ -48,8 +49,8 @@ public VersionedApiExplorer( HttpConfiguration configuration )
     public VersionedApiExplorer( HttpConfiguration configuration, ApiExplorerOptions options )
     {
         Configuration = configuration;
-        Options = options;
-        apiDescriptions = new( InitializeApiDescriptions );
+        this.options = options;
+        apiDescriptions = new( Initialize );
     }
 
     /// <summary>
@@ -80,7 +81,7 @@ public IDocumentationProvider DocumentationProvider
     /// Gets the options associated with the API explorer.
     /// </summary>
     /// <value>The <see cref="ApiExplorerOptions">API explorer options</see>.</value>
-    protected virtual ApiExplorerOptions Options { get; }
+    protected virtual ApiExplorerOptions Options => options;
 
     /// <summary>
     /// Gets the comparer used to compare API descriptions.
@@ -205,6 +206,8 @@ protected virtual string GetGroupName( ApiVersion apiVersion )
         return apiVersion.ToString( Options.GroupNameFormat, InvariantCulture );
     }
 
+    private ApiDescriptionGroupCollection Initialize() => InitializeApiDescriptions();
+
     /// <summary>
     /// Initializes the API descriptions to explore.
     /// </summary>

src/AspNet/WebApi/src/Asp.Versioning.WebApi/Dispatcher/ApiVersionControllerSelector.cs

@@ -251,8 +251,6 @@ private static HttpControllerDescriptor[] ApplyCollatedModels(
         List<HttpControllerDescriptor> controllers,
         IHttpActionSelector actionSelector )
     {
-        var supported = new HashSet<ApiVersion>();
-        var deprecated = new HashSet<ApiVersion>();
         var controllerModels = new List<ApiVersionModel>( controllers.Count );
         var actionModels = new List<ApiVersionModel>( controllers.Count );
         var visitedControllers = new List<Tuple<HttpControllerDescriptor, ApiVersionModel>>( controllers.Count );