Add acceptance tests

Author: Chris Martinez

test/Microsoft.AspNet.WebApi.Acceptance.Tests/OData/Basic/BasicAcceptanceTest.cs

@@ -40,7 +40,7 @@ protected BasicAcceptanceTest()
         }
 
         [Fact]
-        public async Task service_document_should_return_400_for_unsupported_url_api_version()
+        public async Task then_service_document_should_return_400_for_unsupported_url_api_version()
         {
             // arrange
             var requestUrl = $"v4";
@@ -55,7 +55,7 @@ public async Task service_document_should_return_400_for_unsupported_url_api_ver
         }
 
         [Fact]
-        public async Task metadata_should_return_400_for_unsupported_url_api_version()
+        public async Task then_X24metadata_should_return_400_for_unsupported_url_api_version()
         {
             // arrange
 

test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/AcceptanceTest.cs

@@ -5,19 +5,15 @@
     using Builder;
     using Extensions.DependencyInjection;
     using Hosting;
-    using Microsoft.AspNetCore.Mvc.Razor;
     using System;
     using System.Collections.Generic;
     using System.IO;
-    using System.Linq;
     using System.Net.Http;
     using System.Reflection;
     using TestHost;
     using Versioning;
     using Xunit;
-    using static Microsoft.CodeAnalysis.MetadataReference;
     using static Microsoft.Extensions.DependencyInjection.ServiceDescriptor;
-    using static System.Reflection.Assembly;
 
     [Trait( "Framework", "ASP.NET Core" )]
     public abstract partial class AcceptanceTest : IDisposable
@@ -66,7 +62,7 @@ TestServer CreateServer()
         {
             var builder = new WebHostBuilder()
                 .Configure( app => app.UseMvc( OnConfigureRoutes ).UseMvcWithDefaultRoute() )
-                .ConfigureServices( OnConfigureServices )
+                .ConfigureServices( OnDefaultConfigureServices )
                 .UseContentRoot( GetContentRoot() );
 
             return new TestServer( builder );
@@ -79,33 +75,15 @@ HttpClient CreateAndInitializeHttpClient()
             return newClient;
         }
 
-        void OnConfigureServices( IServiceCollection services )
+        void OnDefaultConfigureServices( IServiceCollection services )
         {
             var partManager = new ApplicationPartManager();
 
-            partManager.FeatureProviders.Add( filteredControllerTypes );
-            partManager.ApplicationParts.Add( new AssemblyPart( GetType().GetTypeInfo().Assembly ) );
+            OnConfigurePartManager( partManager );
             services.Add( Singleton( partManager ) );
             services.AddMvc();
             services.AddApiVersioning( OnAddApiVersioning );
-            services.Configure<RazorViewEngineOptions>( options =>
-            {
-                options.CompilationCallback += context =>
-                {
-                    var assembly = GetType().GetTypeInfo().Assembly;
-                    var assemblies = assembly.GetReferencedAssemblies().Select( x => CreateFromFile( Load( x ).Location ) ).ToList();
-
-                    assemblies.Add( CreateFromFile( Load( new AssemblyName( "mscorlib" ) ).Location ) );
-#if NET461
-                    assemblies.Add( CreateFromFile( Load( new AssemblyName( "netstandard" ) ).Location ) );
-#else
-                    assemblies.Add( CreateFromFile( Load( new AssemblyName( "System.Private.Corelib" ) ).Location ) );
-#endif
-                    assemblies.Add( CreateFromFile( Load( new AssemblyName( "System.Dynamic.Runtime" ) ).Location ) );
-                    assemblies.Add( CreateFromFile( Load( new AssemblyName( "Microsoft.AspNetCore.Razor" ) ).Location ) );
-                    context.Compilation = context.Compilation.AddReferences( assemblies );
-                };
-            } );
+            OnConfigureServices( services );
         }
 
         string GetContentRoot()
@@ -121,6 +99,11 @@ string GetContentRoot()
             return contentRoot.FullName;
         }
 
+        protected virtual void OnConfigurePartManager( ApplicationPartManager partManager ) =>
+            partManager.ApplicationParts.Add( new TestApplicationPart( FilteredControllerTypes ) );
+
+        protected virtual void OnConfigureServices( IServiceCollection services ) { }
+
         protected abstract void OnAddApiVersioning( ApiVersioningOptions options );
 
         protected virtual void OnConfigureRoutes( IRouteBuilder routeBuilder ) { }

test/Microsoft.AspNetCore.Mvc.Acceptance.Tests/Microsoft.AspNetCore.Mvc.Acceptance.Tests.csproj

@@ -2,17 +2,19 @@
 
  <PropertyGroup>
   <TargetFrameworks>netcoreapp2.0;net461</TargetFrameworks>
+  <RootNamespace>Microsoft.AspNetCore</RootNamespace>
   <TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
   <AssetTargetFallback>$(AssetTargetFallback);portable-net451+win8</AssetTargetFallback>
   <PreserveCompilationContext>true</PreserveCompilationContext>
  </PropertyGroup>
 
  <ItemGroup>
   <ProjectReference Include="..\..\src\Microsoft.AspNetCore.Mvc.Versioning\Microsoft.AspNetCore.Mvc.Versioning.csproj" />
+  <ProjectReference Include="..\..\src\Microsoft.AspNetCore.OData.Versioning\Microsoft.AspNetCore.OData.Versioning.csproj" />
  </ItemGroup>
 
  <ItemGroup>
-  <PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="5.2.4-*" />
+  <PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="5.2.6" />
   <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.0" />
   <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.0.0" />
   <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />