From 42f86252c0802317bf9faea36ee79875ce7ef05a Mon Sep 17 00:00:00 2001
From: Parker Bibus <parker.bibus@microsoft.com>
Date: Thu, 20 Aug 2026 14:10:13 -0700
Subject: [PATCH] Fix MAUI Android inner loop MSBuild arg splitting on Helix

The coreclr _MSBuildArgs value joined /p:PublishReadyToRun and /p:PublishReadyToRunComposite with ';'. Since _MSBuildArgs is passed to Helix as a single quoted argument and Helix treats ';' as a command separator when generating the run script, the semicolons split the quoted argument across separate command lines. This caused setup_helix.py to receive only the first arg and the remaining /p: args to run as standalone commands (failing with 'The filename, directory name, or volume label syntax is incorrect').

Use spaces instead, matching every other append in the PropertyGroup. The Python side already splits on [;\s]+, so args still parse correctly.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0cabccd5-6263-4ed9-abe7-a8da6c6979a3
---
 eng/performance/maui_scenarios_android_innerloop.proj | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/eng/performance/maui_scenarios_android_innerloop.proj b/eng/performance/maui_scenarios_android_innerloop.proj
index 33864f5de4a..8613ff4a984 100644
--- a/eng/performance/maui_scenarios_android_innerloop.proj
+++ b/eng/performance/maui_scenarios_android_innerloop.proj
@@ -16,8 +16,13 @@
     <_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'mono'">/p:UseMonoRuntime=true</_MSBuildArgs>
     <_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">/p:UseMonoRuntime=false</_MSBuildArgs>
 
-    <!-- CoreCLR: disable ReadyToRun so inner loop measures JIT behavior -->
-    <_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">$(_MSBuildArgs);/p:PublishReadyToRun=false;/p:PublishReadyToRunComposite=false</_MSBuildArgs>
+    <!-- CoreCLR: disable ReadyToRun so inner loop measures JIT behavior.
+         Use spaces (not ';') to separate args: _MSBuildArgs is passed as a
+         single quoted argument in the Helix PreCommands/Command, and Helix
+         treats ';' as a command separator when generating the run script
+         (that's why the env-var 'set ...;set ...' blocks work). A ';' here
+         would split the quoted argument across separate command lines. -->
+    <_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">$(_MSBuildArgs) /p:PublishReadyToRun=false /p:PublishReadyToRunComposite=false</_MSBuildArgs>
 
     <!-- AndroidRid: defaults based on target OS but can be overridden.
          Windows targets physical devices; Linux targets emulators. -->