What
At the moment classes SkeletonEventBase, SkeletonFieldBase and SkeletonMethodBase define the public method
void UpdateSkeletonReference(SkeletonBase& skeleton_base) noexcept;
used to update the SkeletonBase for that element, which will be called when the Skeleton is getting moved.
This does not have to be public API, but instead should be a private method, with SkeletonBase being added as a friend to the earlier mentioned element base classes so that the method can be called upon move.
How
Add SkeletonBase as a friend class and switch visibility of "UpdateSkeletonReference" to private.
Estimates for realization
Low effort change. Method UpdateSkeletonReference should have only be used by SkeletonBase so far.
Category
Requirements / Architecture
What
At the moment classes SkeletonEventBase, SkeletonFieldBase and SkeletonMethodBase define the public method
void UpdateSkeletonReference(SkeletonBase& skeleton_base) noexcept;used to update the SkeletonBase for that element, which will be called when the Skeleton is getting moved.
This does not have to be public API, but instead should be a private method, with SkeletonBase being added as a friend to the earlier mentioned element base classes so that the method can be called upon move.
How
Add SkeletonBase as a friend class and switch visibility of "UpdateSkeletonReference" to private.
Estimates for realization
Low effort change. Method UpdateSkeletonReference should have only be used by SkeletonBase so far.
Category
Requirements / Architecture