diff --git a/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionFactory.java b/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionFactory.java index 515370e3c..6f5f652ef 100644 --- a/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionFactory.java +++ b/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/MSSQLConnectionFactory.java @@ -16,17 +16,18 @@ import io.vertx.core.Promise; import io.vertx.core.internal.ContextInternal; import io.vertx.core.internal.VertxInternal; +import io.vertx.core.internal.net.NetSocketInternal; import io.vertx.core.internal.tls.SslContextManager; import io.vertx.core.net.HostAndPort; +import io.vertx.core.net.NetClientOptions; import io.vertx.core.net.NetSocket; import io.vertx.core.net.SocketAddress; -import io.vertx.core.internal.net.NetSocketInternal; import io.vertx.core.spi.metrics.ClientMetrics; import io.vertx.core.spi.metrics.VertxMetrics; import io.vertx.mssqlclient.MSSQLConnectOptions; import io.vertx.sqlclient.SqlConnection; -import io.vertx.sqlclient.internal.Connection; import io.vertx.sqlclient.impl.ConnectionFactoryBase; +import io.vertx.sqlclient.internal.Connection; import java.util.Map; @@ -37,7 +38,11 @@ public class MSSQLConnectionFactory extends ConnectionFactoryBase connect @Override public ConnectionFactory createConnectionFactory(Vertx vertx, NetClientOptions transportOptions) { - return new MSSQLConnectionFactory((VertxInternal) vertx); + return new MSSQLConnectionFactory((VertxInternal) vertx, transportOptions); } @Override diff --git a/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionFactory.java b/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionFactory.java index 30aa1d410..6762d2953 100644 --- a/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionFactory.java +++ b/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/impl/MySQLConnectionFactory.java @@ -17,20 +17,16 @@ import io.vertx.core.buffer.Buffer; import io.vertx.core.internal.ContextInternal; import io.vertx.core.internal.VertxInternal; -import io.vertx.core.net.ConnectOptions; -import io.vertx.core.net.ClientSSLOptions; -import io.vertx.core.net.NetSocket; -import io.vertx.core.net.SocketAddress; -import io.vertx.core.net.TrustOptions; import io.vertx.core.internal.net.NetSocketInternal; +import io.vertx.core.net.*; import io.vertx.core.spi.metrics.ClientMetrics; import io.vertx.core.spi.metrics.VertxMetrics; import io.vertx.mysqlclient.MySQLAuthenticationPlugin; import io.vertx.mysqlclient.MySQLConnectOptions; import io.vertx.mysqlclient.SslMode; import io.vertx.sqlclient.SqlConnection; -import io.vertx.sqlclient.internal.Connection; import io.vertx.sqlclient.impl.ConnectionFactoryBase; +import io.vertx.sqlclient.internal.Connection; import java.nio.charset.Charset; import java.util.Map; @@ -44,6 +40,10 @@ public MySQLConnectionFactory(VertxInternal vertx) { super(vertx); } + public MySQLConnectionFactory(VertxInternal vertx, NetClientOptions tranportOptions) { + super(vertx, tranportOptions); + } + @Override protected Future doConnectInternal(MySQLConnectOptions options, ContextInternal context) { SslMode sslMode = options.isUsingDomainSocket() ? SslMode.DISABLED : options.getSslMode(); diff --git a/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/spi/MySQLDriver.java b/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/spi/MySQLDriver.java index 76c8422f7..00525710c 100644 --- a/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/spi/MySQLDriver.java +++ b/vertx-mysql-client/src/main/java/io/vertx/mysqlclient/spi/MySQLDriver.java @@ -24,15 +24,18 @@ import io.vertx.core.json.JsonObject; import io.vertx.core.net.NetClientOptions; import io.vertx.mysqlclient.MySQLConnectOptions; -import io.vertx.mysqlclient.impl.*; +import io.vertx.mysqlclient.impl.MySQLConnectionFactory; +import io.vertx.mysqlclient.impl.MySQLConnectionImpl; +import io.vertx.mysqlclient.impl.MySQLConnectionUriParser; +import io.vertx.mysqlclient.impl.MySQLPoolOptions; import io.vertx.sqlclient.Pool; import io.vertx.sqlclient.PoolOptions; import io.vertx.sqlclient.SqlConnectOptions; import io.vertx.sqlclient.SqlConnection; import io.vertx.sqlclient.internal.Connection; +import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.internal.pool.CloseablePool; import io.vertx.sqlclient.internal.pool.PoolImpl; -import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.spi.ConnectionFactory; import io.vertx.sqlclient.spi.Driver; @@ -83,7 +86,7 @@ public boolean acceptsOptions(SqlConnectOptions options) { @Override public ConnectionFactory createConnectionFactory(Vertx vertx, NetClientOptions transportOptions) { - return new MySQLConnectionFactory((VertxInternal) vertx); + return new MySQLConnectionFactory((VertxInternal) vertx, transportOptions); } @Override diff --git a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionFactory.java b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionFactory.java index f19fdfc1c..55997385a 100644 --- a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionFactory.java +++ b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionFactory.java @@ -13,7 +13,6 @@ import io.vertx.core.Completable; import io.vertx.core.Context; import io.vertx.core.Future; -import io.vertx.core.Promise; import io.vertx.core.internal.ContextInternal; import io.vertx.core.internal.VertxInternal; import io.vertx.core.json.JsonObject; @@ -36,7 +35,7 @@ public class OracleConnectionFactory implements ConnectionFactory datasources; - public OracleConnectionFactory(VertxInternal vertx) { + public OracleConnectionFactory() { this.datasources = new HashMap<>(); } diff --git a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionImpl.java b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionImpl.java index 6c428c0b3..c01a3067b 100644 --- a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionImpl.java +++ b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/impl/OracleConnectionImpl.java @@ -29,7 +29,7 @@ public OracleConnectionImpl(ContextInternal context, ConnectionFactory factory, public static Future connect(Vertx vertx, OracleConnectOptions options) { ContextInternal ctx = (ContextInternal) vertx.getOrCreateContext(); - OracleConnectionFactory client = new OracleConnectionFactory(ctx.owner()); + OracleConnectionFactory client = new OracleConnectionFactory(); return prepareForClose(ctx, client.connect(ctx, options)).map(OracleConnection::cast); } } diff --git a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/spi/OracleDriver.java b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/spi/OracleDriver.java index d7f7083bc..23b48295b 100644 --- a/vertx-oracle-client/src/main/java/io/vertx/oracleclient/spi/OracleDriver.java +++ b/vertx-oracle-client/src/main/java/io/vertx/oracleclient/spi/OracleDriver.java @@ -19,15 +19,18 @@ import io.vertx.core.json.JsonObject; import io.vertx.core.net.NetClientOptions; import io.vertx.oracleclient.OracleConnectOptions; -import io.vertx.oracleclient.impl.*; +import io.vertx.oracleclient.impl.OracleConnectionFactory; +import io.vertx.oracleclient.impl.OracleConnectionImpl; +import io.vertx.oracleclient.impl.OracleConnectionUriParser; +import io.vertx.oracleclient.impl.OracleJdbcConnection; import io.vertx.sqlclient.Pool; import io.vertx.sqlclient.PoolOptions; import io.vertx.sqlclient.SqlConnectOptions; import io.vertx.sqlclient.SqlConnection; import io.vertx.sqlclient.internal.Connection; +import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.internal.pool.CloseablePool; import io.vertx.sqlclient.internal.pool.PoolImpl; -import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.spi.ConnectionFactory; import io.vertx.sqlclient.spi.Driver; @@ -80,7 +83,7 @@ public boolean acceptsOptions(SqlConnectOptions options) { @Override public ConnectionFactory createConnectionFactory(Vertx vertx, NetClientOptions transportOptions) { - return new OracleConnectionFactory((VertxInternal) vertx); + return new OracleConnectionFactory(); } @Override diff --git a/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java b/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java index 289b84786..02b48652a 100644 --- a/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java +++ b/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/PgConnectionFactory.java @@ -19,18 +19,18 @@ import io.vertx.core.Context; import io.vertx.core.Future; -import io.vertx.core.net.*; -import io.vertx.core.spi.metrics.ClientMetrics; -import io.vertx.core.spi.metrics.VertxMetrics; import io.vertx.core.internal.ContextInternal; import io.vertx.core.internal.PromiseInternal; import io.vertx.core.internal.VertxInternal; import io.vertx.core.internal.net.NetSocketInternal; +import io.vertx.core.net.*; +import io.vertx.core.spi.metrics.ClientMetrics; +import io.vertx.core.spi.metrics.VertxMetrics; import io.vertx.pgclient.PgConnectOptions; import io.vertx.pgclient.SslMode; import io.vertx.sqlclient.SqlConnection; -import io.vertx.sqlclient.internal.Connection; import io.vertx.sqlclient.impl.ConnectionFactoryBase; +import io.vertx.sqlclient.internal.Connection; import java.util.Collections; import java.util.Map; @@ -41,8 +41,12 @@ */ public class PgConnectionFactory extends ConnectionFactoryBase { - public PgConnectionFactory(VertxInternal context) { - super(context); + public PgConnectionFactory(VertxInternal vertx) { + super(vertx); + } + + public PgConnectionFactory(VertxInternal vertx, NetClientOptions transportOptions) { + super(vertx, transportOptions); } private void checkSslMode(PgConnectOptions options) { diff --git a/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java b/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java index 80f899ef5..552986e57 100644 --- a/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java +++ b/vertx-pg-client/src/main/java/io/vertx/pgclient/spi/PgDriver.java @@ -3,11 +3,11 @@ import io.vertx.core.Future; import io.vertx.core.Handler; import io.vertx.core.Vertx; -import io.vertx.core.json.JsonObject; -import io.vertx.core.net.NetClientOptions; import io.vertx.core.internal.CloseFuture; import io.vertx.core.internal.ContextInternal; import io.vertx.core.internal.VertxInternal; +import io.vertx.core.json.JsonObject; +import io.vertx.core.net.NetClientOptions; import io.vertx.pgclient.PgConnectOptions; import io.vertx.pgclient.impl.PgConnectionFactory; import io.vertx.pgclient.impl.PgConnectionImpl; @@ -18,9 +18,9 @@ import io.vertx.sqlclient.SqlConnectOptions; import io.vertx.sqlclient.SqlConnection; import io.vertx.sqlclient.internal.Connection; +import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.internal.pool.CloseablePool; import io.vertx.sqlclient.internal.pool.PoolImpl; -import io.vertx.sqlclient.internal.SqlConnectionInternal; import io.vertx.sqlclient.spi.ConnectionFactory; import io.vertx.sqlclient.spi.Driver; @@ -71,7 +71,7 @@ public PgConnectOptions downcast(SqlConnectOptions connectOptions) { @Override public ConnectionFactory createConnectionFactory(Vertx vertx, NetClientOptions transportOptions) { - return new PgConnectionFactory((VertxInternal) vertx); + return new PgConnectionFactory((VertxInternal) vertx, transportOptions); } @Override