Skip to content

Segfault in all spr commands in 0.17.6 but not 0.17.1, possibly with the github keychain thing? #511

@cadolphs

Description

@cadolphs
> github fetch pull requests
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1047e02a0]

goroutine 1 [running]:
github.com/ejoffe/spr/github/githubclient.(*client).GetInfo(0x14000222f60, {0x104a5cfd8, 0x104eb6ce0}, {0x104a5d7f0, 0x1400022bd40})
	/Users/runner/work/spr/spr/github/githubclient/client.go:213 +0x130
github.com/ejoffe/spr/spr.(*stackediff).MergePullRequests(0x14000246310, {0x104a5cfd8, 0x104eb6ce0}, 0x140001b5aa8)
	/Users/runner/work/spr/spr/spr/spr.go:439 +0x80
main.main.func6(0x14000250480?)
	/Users/runner/work/spr/spr/cmd/spr/main.go:276 +0x74
github.com/urfave/cli/v2.(*Command).Run(0x14000250480, 0x14000214a40)
	/Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/command.go:169 +0x4f8
github.com/urfave/cli/v2.(*App).RunContext(0x14000256000, {0x104a5cfd8?, 0x104eb6ce0}, {0x14000032080, 0x4, 0x4})
	/Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/app.go:341 +0x85c
github.com/urfave/cli/v2.(*App).Run(...)
	/Users/runner/go/pkg/mod/github.com/urfave/cli/v2@v2.8.1/app.go:247
main.main()
	/Users/runner/work/spr/spr/cmd/spr/main.go:365 +0x1b4```

with just about any spr command after upgrading to latest version. Checked the changelog, wondering what caused it. For me might be the github token? I'm using the gh cli to manage authentication, not the macos keychain or anything else.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions