Migrate elasticstack_elasticsearch_security_role resource to Plugin Framework (#1331)

* Initial plan

* Implement Plugin Framework role resource structure and basic functionality

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

* Complete Plugin Framework role resource migration with documentation

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

* Address PR feedback: use jsontypes, remove redundant code, add helper functions

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

* Fix schema to use nested blocks and run acceptance tests successfully

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

* Fix IsNull vs IsKnown checks and reorganize attribute type definitions

Co-authored-by: tobio <444668+tobio@users.noreply.github.com>

* Fix tests

* Remove old acceptance tests

* RunAs

* Remove old role resource

* Tidy up diags

* Field security should be a single nested block

* Field security should be a block in indices

Moving to an attribute is a breaking change with no benefit at the moment

* Bump SDK test to 0.12.2

* Skip SDK test when unsupported

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tobio <444668+tobio@users.noreply.github.com>
Co-authored-by: Toby Brain <toby.brain@elastic.co>

Author: Copilot

CHANGELOG.md

@@ -40,6 +40,7 @@ alias = [
 
 ### Changes
 
+- Migrate `elasticstack_elasticsearch_security_role` resource to Terraform Plugin Framework ([#1330](https://github.com/elastic/terraform-provider-elasticstack/pull/1330))
 - Fix an issue where the `elasticstack_fleet_output` resource would error due to inconsistent state after an ouptut was edited in the Kibana UI ([#1506](https://github.com/elastic/terraform-provider-elasticstack/pull/1506))
 - Allow `index` and `data_view_id` values to both be unknown during planning in `elasticstack_kibana_security_detection_rule` ([#1499](https://github.com/elastic/terraform-provider-elasticstack/pull/1499))
 - Support `.bedrock` and `.gen-ai` connectors ([#1467](https://github.com/elastic/terraform-provider-elasticstack/pull/1467))

docs/resources/elasticsearch_security_role.md

@@ -3,12 +3,12 @@
 page_title: "elasticstack_elasticsearch_security_role Resource - terraform-provider-elasticstack"
 subcategory: "Security"
 description: |-
-  Adds and updates roles in the native realm. See the security API put role documentation https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-role.html for more details.
+  Adds and updates roles in the native realm. See the role API documentation https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-role.html for more details.
 ---
 
 # elasticstack_elasticsearch_security_role (Resource)
 
-Adds and updates roles in the native realm. See the [security API put role documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-role.html) for more details.
+Adds and updates roles in the native realm. See the [role API documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-put-role.html) for more details.
 
 ## Example Usage
 
@@ -57,7 +57,7 @@ output "role" {
 - `applications` (Block Set) A list of application privilege entries. (see [below for nested schema](#nestedblock--applications))
 - `cluster` (Set of String) A list of cluster privileges. These privileges define the cluster level actions that users with this role are able to execute.
 - `description` (String) The description of the role.
-- `elasticsearch_connection` (Block List, Max: 1, Deprecated) Elasticsearch connection configuration block. This property will be removed in a future provider version. Configure the Elasticsearch connection via the provider configuration instead. (see [below for nested schema](#nestedblock--elasticsearch_connection))
+- `elasticsearch_connection` (Block List, Deprecated) Elasticsearch connection configuration block. (see [below for nested schema](#nestedblock--elasticsearch_connection))
 - `global` (String) An object defining global privileges.
 - `indices` (Block Set) A list of indices permissions entries. (see [below for nested schema](#nestedblock--indices))
 - `metadata` (String) Optional meta-data.
@@ -110,7 +110,7 @@ Required:
 Optional:
 
 - `allow_restricted_indices` (Boolean) Include matching restricted indices in names parameter. Usage is strongly discouraged as it can grant unrestricted operations on critical data, make the entire system unstable or leak sensitive information.
-- `field_security` (Block List, Max: 1) The document fields that the owners of the role have read access to. (see [below for nested schema](#nestedblock--indices--field_security))
+- `field_security` (Block, Optional) The document fields that the owners of the role have read access to. (see [below for nested schema](#nestedblock--indices--field_security))
 - `query` (String) A search query that defines the documents the owners of the role have read access to.
 
 <a id="nestedblock--indices--field_security"></a>
@@ -134,7 +134,7 @@ Required:
 
 Optional:
 
-- `field_security` (Block List, Max: 1) The document fields that the owners of the role have read access to. (see [below for nested schema](#nestedblock--remote_indices--field_security))
+- `field_security` (Block, Optional) The document fields that the owners of the role have read access to. (see [below for nested schema](#nestedblock--remote_indices--field_security))
 - `query` (String) A search query that defines the documents the owners of the role have read access to.
 
 <a id="nestedblock--remote_indices--field_security"></a>

internal/elasticsearch/security/api_key/acc_test.go

@@ -135,10 +135,12 @@ func TestAccResourceSecurityApiKeyWithRemoteIndices(t *testing.T) {
 									AllowRestrictedIndices: utils.Pointer(false),
 								}},
 								RemoteIndices: []models.RemoteIndexPerms{{
-									Clusters:               []string{"*"},
-									Names:                  []string{"index-a*"},
-									Privileges:             []string{"read"},
-									AllowRestrictedIndices: utils.Pointer(true),
+									Clusters: []string{"*"},
+									IndexPerms: models.IndexPerms{
+										Names:                  []string{"index-a*"},
+										Privileges:             []string{"read"},
+										AllowRestrictedIndices: utils.Pointer(true),
+									},
 								}},
 							},
 						}