Add trace helper to ExUnit.Assertions#15432
Merged
Merged
Conversation
josevalim
reviewed
Jun 2, 2026
josevalim
reviewed
Jun 2, 2026
josevalim
reviewed
Jun 2, 2026
josevalim
reviewed
Jun 2, 2026
josevalim
reviewed
Jun 8, 2026
josevalim
reviewed
Jun 8, 2026
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
9c2e00e to
3f9cd6e
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started in phoenixframework/phoenix_live_view#4242.
Imagine that you are testing a LiveView (or any process like a GenServer) that is subscribed to messages from another process (could be Phoenix PubSub). In a test, you trigger a process that will eventually deliver that message (but you don't control the exact timing), and you need to assert on the rendered result of the LiveView (GenServer state):
If there's no guarantee that the LiveView already received the message from
do_workwhen callingrender, this test is flaky. For example, if another process is involved, scheduling might cause the message to arrive only after therenderGenServer call.One workaround would be to retry the assertion, which arguably is not a nice solution:
By introducing a trace helper, the test can ensure that the LiveView handled the message before it asserts on its rendered state:
This PR adds a new
trace/3(andtrace/4) helper toExUnit.Assertions, implemented as a light wrapper around Erlang's:tracesessions, introduced in OTP 27.