Merge pull request #861 from ember-learn/fix-tests

skip tests that are broken because of invalid data in production

Author: mansona

tests/acceptance/function-test.js

@@ -5,7 +5,7 @@ import { visit, find } from '@ember/test-helpers';
 module('Acceptance | Function', function (hooks) {
   setupApplicationTest(hooks);
 
-  test('shows function when loaded from url', async function (assert) {
+  test.skip('shows function when loaded from url', async function (assert) {
     await visit('ember/2.18/functions/@ember%2Fapplication/getOwner');
 
     assert.dom('.method').exists({ count: 1 }, 'Single function per page');
@@ -15,4 +15,15 @@ module('Acceptance | Function', function (hooks) {
       'Correct function is shown'
     );
   });
+
+  test('shows function when loaded from url in a more modern version', async function (assert) {
+    await visit('ember/3.28/functions/@ember%2Fapplication/getOwner');
+
+    assert.dom('.method').exists({ count: 1 }, 'Single function per page');
+    assert.equal(
+      find('.method .method-name').innerText,
+      'getOwner',
+      'Correct function is shown'
+    );
+  });
 });

tests/acceptance/switch-versions-test.js

@@ -271,7 +271,7 @@ module('Acceptance | version navigation', function (hooks) {
     );
   });
 
-  test('switching versions works if class name includes slashes', async function (assert) {
+  test.skip('switching versions works if class name includes slashes', async function (assert) {
     await visit('/ember/3.4/classes/@ember%2Fobject%2Fcomputed');
     assert.equal(
       currentURL(),
@@ -287,7 +287,23 @@ module('Acceptance | version navigation', function (hooks) {
     );
   });
 
-  test(`switching versions works if we've previously switched for a different class`, async function (assert) {
+  test('switching versions works if class name includes slashes for more modern versions', async function (assert) {
+    await visit('/ember/3.13/classes/@ember%2Fobject%2Fcomputed');
+    assert.equal(
+      currentURL(),
+      '/ember/3.13/classes/@ember%2Fobject%2Fcomputed',
+      'navigated to v3.13 class'
+    );
+    await selectChoose('.ember-power-select-trigger', '3.20');
+    await waitForSettled();
+    assert.equal(
+      currentURL(),
+      '/ember/3.20/classes/@ember%2Fobject%2Fcomputed',
+      'navigated to v3.20 class'
+    );
+  });
+
+  test.skip(`switching versions works if we've previously switched for a different class`, async function (assert) {
     await visit('/ember/3.4/classes/@ember%2Fobject%2Fcomputed');
     assert.equal(
       currentURL(),
@@ -316,6 +332,36 @@ module('Acceptance | version navigation', function (hooks) {
     );
   });
 
+  test(`switching versions works if we've previously switched for a different class (for more modern versions)`, async function (assert) {
+    await visit('/ember/3.13/classes/@ember%2Fobject%2Fcomputed');
+    assert.equal(
+      currentURL(),
+      '/ember/3.13/classes/@ember%2Fobject%2Fcomputed',
+      'navigated to v3.13 class'
+    );
+    await selectChoose('.ember-power-select-trigger', '3.20');
+    await waitForSettled();
+    assert.equal(
+      currentURL(),
+      '/ember/3.20/classes/@ember%2Fobject%2Fcomputed',
+      'navigated to v3.20 class'
+    );
+
+    await visit('/ember/3.25/classes/Component');
+    assert.equal(
+      currentURL(),
+      '/ember/3.25/classes/Component',
+      'navigated to new class'
+    );
+    await selectChoose('.ember-power-select-trigger', '3.15');
+    await waitForSettled();
+    assert.equal(
+      currentURL(),
+      '/ember/3.15/classes/Component',
+      'navigated to v3.15 for new class'
+    );
+  });
+
   test(`can switch to ember 1.13`, async function (assert) {
     await visit('/ember/2.0/classes/Ember.Component');
     await waitForSettled();