Merge pull request #393 from ember-learn/upgrade-ember-3.13

Upgrade v2 tracking branch to Ember 3.13

Author: mansona

.eslintignore

@@ -8,6 +8,7 @@
 
 # dependencies
 /bower_components/
+/node_modules/
 
 # misc
 /coverage/

.eslintrc.js

@@ -1,7 +1,8 @@
 module.exports = {
   root: true,
+  parser: 'babel-eslint',
   parserOptions: {
-    ecmaVersion: 2017,
+    ecmaVersion: 2018,
     sourceType: 'module'
   },
   plugins: [
@@ -15,7 +16,7 @@ module.exports = {
     browser: true
   },
   rules: {
-    'no-useless-escape': 'off'
+    'ember/no-jquery': 'error'
   },
   overrides: [
     // node files
@@ -29,7 +30,8 @@ module.exports = {
         'testem.js',
         'blueprints/*/index.js',
         'config/**/*.js',
-        'tests/dummy/config/**/*.js'
+        'tests/dummy/config/**/*.js',
+        'port.js'
       ],
       excludedFiles: [
         'addon/**',
@@ -38,8 +40,7 @@ module.exports = {
         'tests/dummy/app/**'
       ],
       parserOptions: {
-        sourceType: 'script',
-        ecmaVersion: 2015
+        sourceType: 'script'
       },
       env: {
         browser: false,

.github/workflows/ci.yml

@@ -0,0 +1,65 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - v[0-9]+.[0-9]+.[0-9]+
+  pull_request:
+
+env:
+  NODE_VERSION: 10
+
+jobs:
+  test:
+    name: Lint and Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: mansona/npm-lockfile-version@v1
+      - uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - run: npm i -g npm@7
+      - run: npm ci
+      - run: npm run lint:hbs
+      - run: npm run lint:js
+      - run: npm run test
+
+
+  test-addon-floating:
+    name: Test addon (floating dependencies)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - run: npm i -g npm@7
+      - run: npm install --no-package-lock
+      - run: npm run test
+
+  test-compatibility:
+    name: Test compatibility
+    runs-on: ubuntu-latest
+    needs: test
+    strategy:
+      matrix:
+        scenario:
+          - 'ember-release'
+          - 'ember-beta'
+          - 'ember-canary'
+          - 'ember-default-with-jquery'
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - run: npm i -g npm@7
+      - run: npm ci
+      - name: Test
+        run: npx ember try:one $EMBER_TRY_SCENARIO ${{ matrix.scenario }}

.gitignore

@@ -9,16 +9,20 @@
 /node_modules/
 
 # misc
+/.env*
+/.pnp*
 /.sass-cache
 /connect.lock
 /coverage/
 /libpeerconnection.log
 /npm-debug.log*
 /testem.log
 /yarn-error.log
-package-lock.json
 
 # ember-try
 /.node_modules.ember-try/
 /bower.json.ember-try
 /package.json.ember-try
+
+.vscode
+.changelog

.npmignore

@@ -9,14 +9,17 @@
 /.bowerrc
 /.editorconfig
 /.ember-cli
+/.env*
 /.eslintignore
 /.eslintrc.js
+/.git/
 /.gitignore
 /.template-lintrc.js
 /.travis.yml
 /.watchmanconfig
 /bower.json
 /config/ember-try.js
+/CONTRIBUTING.md
 /ember-cli-build.js
 /testem.js
 /tests/

.travis.yml

@@ -0,0 +1,26 @@
+# How To Contribute
+
+## Installation
+
+* `git clone <repository-url>`
+* `cd ember-styleguide`
+* `npm install`
+
+## Linting
+
+* `npm run lint:hbs`
+* `npm run lint:js`
+* `npm run lint:js -- --fix`
+
+## Running tests
+
+* `ember test` – Runs the test suite on the current Ember version
+* `ember test --server` – Runs the test suite in "watch mode"
+* `ember try:each` – Runs the test suite against multiple Ember versions
+
+## Running the dummy application
+
+* `ember serve`
+* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
+
+For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).

CONTRIBUTING.md

@@ -1,10 +1,10 @@
 # ember-styleguide [![Build Status](https://travis-ci.org/ember-learn/ember-styleguide.svg?branch=master)](https://travis-ci.org/ember-learn/ember-styleguide) [![Latest NPM release](https://img.shields.io/npm/v/ember-styleguide.svg)](https://www.npmjs.com/package/ember-styleguide.svg)
 
-This addon is intended to provide basic components for easier style coordination among the Ember family of websites, although the original intent is to support the emberjs.com website. We are committed to the goal of meeting WCAG 2.0 AA conformance standards. 
+This addon is intended to provide basic components for easier style coordination among the Ember family of websites, although the original intent is to support the emberjs.com website. We are committed to the goal of meeting WCAG 2.0 AA conformance standards.
 
-Contributions are encouraged! You'll notice that the issues in this repository have been labeled to help you find the issue that is just right for you! 
+Contributions are encouraged! You'll notice that the issues in this repository have been labeled to help you find the issue that is just right for you!
 
-[See the visual design](https://codepen.io/melsumner/pen/9d551738a81e319a773395a2cfa1a82e) as a work in progress & feel free to submit ideas of your own! 
+[See the visual design](https://codepen.io/melsumner/pen/9d551738a81e319a773395a2cfa1a82e) as a work in progress & feel free to submit ideas of your own!
 
 
 
@@ -29,12 +29,11 @@ Contributions are encouraged! You'll notice that the issues in this repository h
 
 * `ember build`
 
-For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
 
 ## WIP Notes
 
 * Each component must have the component name attached to the component as a CSS class.
-* It may feel as though there is duplicated code throughout these components; during the WIP process, we are favoring duplication over abstraction. 
-* Font icons through [ember-fontawesome](https://fontawesome.com/how-to-use/on-the-web/using-with/ember) - it is supported by the font awesome team and they render to SVG. 
+* It may feel as though there is duplicated code throughout these components; during the WIP process, we are favoring duplication over abstraction.
+* Font icons through [ember-fontawesome](https://fontawesome.com/how-to-use/on-the-web/using-with/ember) - it is supported by the font awesome team and they render to SVG.
 * The `es-pagewrapper` component has a property to indicate if there will be a sidebar or not. There might be a better way to do this.
-* In this addon, the `section` element is used as a container and is intended to span the full width of the viewport. 
+* In this addon, the `section` element is used as a container and is intended to span the full width of the viewport.

README.md

@@ -0,0 +1,15 @@
+{{#each releases}}
+  x.x.x / {{isoDate}}
+  ==================
+  {{#if merges}}
+    {{#each merges}}
+      * {{#if commit.breaking}}**Breaking change:** {{/if}}{{message}} #{{id}} from @{{githubIssue.user.login}}
+    {{/each}}
+  {{/if}}
+
+  {{#if fixes}}
+    {{#each fixes}}
+      * FIX: {{#if commit.breaking}}**Breaking change:** {{/if}}{{commit.subject}}{{#each fixes}} {{#if href}}[`#{{id}}`]({{href}}){{/if}}{{/each}}
+    {{/each}}
+  {{/if}}
+{{/each}}