Replacements and scopes

[LarsDenBakker]

I notice some of the codemods are naive in their replacements when it comes to scopes / variable shadowing.

For example let's say the module foo could be replaced with SomeStandard.foo(), we may end up doing:

From:

import foo from 'foo';

foo();

class x {
  someMethod(foo) {
    return foo();
  }
}

To:

SomeStandard.foo(); // that's correct

class x {
  someMethod(foo) {
    return SomeStandard.foo(); // that's not correct
  }
}

Do we think this is a problem, or for the few cases when this can occur we can leave it up to the developer to correct this?

[thepassle]

A lot of the codemods we have currently have pretty straightforward usage (mostly based on looking for usage of that package on github); import the thing, call the imported thing as a function, so as a start I think it's ok. But if we can improve on it, we can/should :)