v2.7.0. breaks i10n auto-detect of language for pad UI

[n-bux]

Hi, thanks for your work and the new 2.7.0 release!

One problem: the pad UI is in English, not detecting my German system. The index page or the timeslider are fine, though.

I tried with my own build off of the official Dockerfile. Same setup works with 2.6.1

When I set it to german (via UI->(cookie) or settings -> lang), it works, off course, only some translations are missing. But these are new features not yet translated, right!?
Examples of missing translations:

• Settings dialogue:
  • Disable Chat
• Timeslider setting dialogue:
  • playback speed (incl. dropdown options)

[JohnMcLear]

Whoa, that sounds rough.. Let me look into it urgently! Any chance you are comfortable running a branch to test from? If so you can clone and test https://github.com/JohnMcLear/etherpad/tree/fix/a11y-dialogs-labels-lang

[n-bux]

thanks for quick answer!
yes, your branch works correctly regarding language detection. but it seems to be based on 2.6.1 (according to http://localhost:9001/health, and also because it is not including the new features like "Diable chat" or playback speed), which was working with me as well..

[JohnMcLear]

I'm really surprised we didn't have testing in for this, I've made and merged an emergency patch and will ask @SamTV12345 to release with it. The patch includes testing to ensure this doesn't happen again..

Apologies.. I'm frustrated this slipped through our testing nets but at least it was a quick fix and a quick release over the coming 24 hours should soften the blow..

cc @translatewiki re missing translations, afaik they land most weeks, I think our development cycle is just ahead of them at the moment :)

Thank you so much for the quick feedback on the release @n-bux - without it we might not have spotted this for far too long!

[SamTV12345]

Thanks for the patch. I will do a release in the evening. Approx. 6 hours from now.

[JohnMcLear]

I will try land some accessibility patches before we release :)

[lucaguindani]

Don't know if it's related, but since 2.7.0 I have translations issues in /admin.

I just tried from a fresh clone from develop running with docker.