fix "uvicorn eval_protocol.utils.logs_server:create_app --factory --reload"

Author: Dylan Huang

eval_protocol/utils/logs_server.py

@@ -288,6 +288,11 @@ def _handle_event(self, event_type: str, data: Any) -> None:
             data = EvaluationRow(**data)
             self.websocket_manager.broadcast_row_upserted(data)
 
+    def start_loops(self):
+        """Start the broadcast loop and evaluation watcher."""
+        self.websocket_manager.start_broadcast_loop()
+        self.evaluation_watcher.start()
+
     async def run_async(self):
         """
         Run the logs server asynchronously with file watching.
@@ -300,11 +305,7 @@ async def run_async(self):
             logger.info(f"Serving files from: {self.build_dir}")
             logger.info("WebSocket endpoint available at /ws")
 
-            # Start the broadcast loop
-            self.websocket_manager.start_broadcast_loop()
-
-            # Start the evaluation watcher
-            self.evaluation_watcher.start()
+            self.start_loops()
 
             config = uvicorn.Config(
                 self.app,
@@ -336,24 +337,26 @@ def run(self):
 
 def create_app(host: str = "localhost", port: int = 8000, build_dir: Optional[str] = None) -> FastAPI:
     """
-    Factory function to create a FastAPI app instance.
+    Factory function to create a FastAPI app instance and start the server with async loops.
 
-    This allows uvicorn to call it with parameters and avoids top-level variable instantiation.
+    This creates a LogsServer instance and starts it in a background thread to ensure
+    all async loops (WebSocket broadcast, evaluation watching) are running.
 
     Args:
         host: Host to bind to
         port: Port to bind to
         build_dir: Optional custom build directory path
 
     Returns:
-        FastAPI app instance
+        FastAPI app instance with server running in background
     """
     if build_dir is None:
         build_dir = os.path.abspath(
             os.path.join(os.path.dirname(os.path.dirname(os.path.dirname(__file__))), "vite-app", "dist")
         )
 
     server = LogsServer(host=host, port=port, build_dir=build_dir)
+    server.start_loops()
     return server.app