Refactor evaluator upload process to ensure secrets are always uploaded first

- Moved the call to `upload_secrets_to_fireworks` to occur before checking the evaluator status, ensuring that secrets are available for evaluation.
- Removed redundant upload of secrets that was previously placed after the evaluator existence check.

Author: Dylan Huang

eval_protocol/cli_commands/create_rft.py

@@ -573,6 +573,14 @@ def _upload_and_ensure_evaluator(
     non_interactive: bool = False,
 ) -> bool:
     """Ensure the evaluator exists and is ACTIVE, uploading it if needed."""
+    # Always upload secrets before checking evaluator status, as secrets may be
+    # needed for evaluation even if the evaluator already exists.
+    upload_secrets_to_fireworks(
+        root=project_root,
+        env_file=env_file,
+        non_interactive=non_interactive,
+    )
+
     # Optional short-circuit: if evaluator already exists and not forcing, skip upload path
     if not force:
         try:
@@ -602,13 +610,6 @@ def _upload_and_ensure_evaluator(
         except requests.exceptions.RequestException:
             pass
 
-    # Upload secrets before ensuring evaluator exists
-    upload_secrets_to_fireworks(
-        root=project_root,
-        env_file=env_file,
-        non_interactive=non_interactive,
-    )
-
     # Ensure evaluator exists by invoking the upload flow programmatically
     try:
         tests = _discover_tests(project_root)