diff --git a/development/notes/plan_forkable_filesystem_rl_scenario.md b/development/notes/plan_forkable_filesystem_rl_scenario.md index f9f729ad..d594e81c 100644 --- a/development/notes/plan_forkable_filesystem_rl_scenario.md +++ b/development/notes/plan_forkable_filesystem_rl_scenario.md @@ -57,9 +57,9 @@ This strategy is preferred over `docker commit` for `mcp/filesystem` because the ### 4.1. Prepare Host Template Directory -* Create a directory structure on the host, e.g.: +* Create a directory structure on the host at a path of your choice, e.g.: ``` - ./mcp_agent_test_templates/fs_move_scenario/ + /path/to/fs_move_scenario/ ├── source_dir/ │ └── file_to_move.txt (contains "Hello from source") └── target_dir/ (empty) @@ -76,7 +76,7 @@ This strategy is preferred over `docker commit` for `mcp/filesystem` because the mcp_transport: "stdio" docker_image: "mcp/filesystem" container_command: ["/data"] # Served directory inside container - template_data_path_host: "./mcp_agent_test_templates/fs_move_scenario/" # Path to host template + template_data_path_host: "/path/to/fs_move_scenario/" # Path to host template # container_volumes can be omitted or will be overridden if template_data_path_host is used for filesystem type ``` diff --git a/examples/mcp_agent_filesystem_rl/test_example.py b/examples/mcp_agent_filesystem_rl/test_example.py index 25ace7f1..ef7c5f73 100644 --- a/examples/mcp_agent_filesystem_rl/test_example.py +++ b/examples/mcp_agent_filesystem_rl/test_example.py @@ -3,7 +3,7 @@ Test script for MCP Agent Filesystem RL Example This script verifies that the example setup is working correctly by: -1. Testing the template directory structure +1. Testing the dataset format 2. Testing the reward function with mock data 3. Testing MCP server connectivity (if running) """ @@ -17,32 +17,12 @@ # Add the eval-protocol package to the path sys.path.insert(0, str(Path(__file__).parent.parent.parent)) -from eval_protocol.models import ( # Ensure EvaluateResult is imported +from eval_protocol.models import ( EvaluateResult, Message, ) -def test_template_structure(): - """Test that the template directory has the correct structure.""" - print("Testing template directory structure...") - - # Construct path relative to this test file, then go to project root and find the template - base_path = Path(__file__).parent.parent.parent - template_path = base_path / "mcp_agent_test_templates" / "fs_rl_example_scenario" - - # Check directories exist - assert template_path.exists(), f"Template directory not found: {template_path}" - assert (template_path / "source_files").exists(), "source_files directory missing" - assert (template_path / "archive").exists(), "archive directory missing" - - # Check important_document.txt exists - important_doc = template_path / "source_files" / "important_document.txt" - assert important_doc.exists(), "important_document.txt missing from source_files" - - print("✓ Template directory structure is correct") - - def test_dataset_format(): """Test that the dataset file is correctly formatted.""" print("Testing dataset format...") diff --git a/mcp_agent_test_templates/fs_move_scenario/source_dir/file_to_move.txt b/mcp_agent_test_templates/fs_move_scenario/source_dir/file_to_move.txt deleted file mode 100644 index 2aeede53..00000000 --- a/mcp_agent_test_templates/fs_move_scenario/source_dir/file_to_move.txt +++ /dev/null @@ -1 +0,0 @@ -Hello from source diff --git a/mcp_agent_test_templates/fs_move_scenario/target_dir/.gitkeep b/mcp_agent_test_templates/fs_move_scenario/target_dir/.gitkeep deleted file mode 100644 index e0e72a2a..00000000 --- a/mcp_agent_test_templates/fs_move_scenario/target_dir/.gitkeep +++ /dev/null @@ -1 +0,0 @@ -# This file is a placeholder to ensure the target_dir is created. diff --git a/mcp_agent_test_templates/fs_rl_example_scenario/archive/.gitkeep b/mcp_agent_test_templates/fs_rl_example_scenario/archive/.gitkeep deleted file mode 100644 index b4ffa907..00000000 --- a/mcp_agent_test_templates/fs_rl_example_scenario/archive/.gitkeep +++ /dev/null @@ -1 +0,0 @@ -# Keep this directory diff --git a/mcp_agent_test_templates/fs_rl_example_scenario/source_files/important_document.txt b/mcp_agent_test_templates/fs_rl_example_scenario/source_files/important_document.txt deleted file mode 100644 index 6f2124b8..00000000 --- a/mcp_agent_test_templates/fs_rl_example_scenario/source_files/important_document.txt +++ /dev/null @@ -1 +0,0 @@ -This is an important document that needs to be archived for safekeeping.