From 25fc925e4560aeaf1517ad6b539d9e38600618f4 Mon Sep 17 00:00:00 2001 From: Damiano Giusti Date: Mon, 5 Nov 2018 15:28:12 +0100 Subject: [PATCH 1/2] Make GestureDetector dispatch single click events --- .../tableview/listener/itemclick/AbstractItemClickListener.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/AbstractItemClickListener.java b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/AbstractItemClickListener.java index 01af6f3b..c4457355 100644 --- a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/AbstractItemClickListener.java +++ b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/AbstractItemClickListener.java @@ -60,7 +60,7 @@ public boolean onSingleTapConfirmed(MotionEvent e) { @Override public boolean onDown(MotionEvent e) { start = e; - return false; + return true; } @Override From 61e8da085445f5f875ecba0f5920b253fe259641 Mon Sep 17 00:00:00 2001 From: Damiano Giusti Date: Mon, 5 Nov 2018 15:29:24 +0100 Subject: [PATCH 2/2] Remove not needed call to GestureDetector onTouchEvent --- .../listener/itemclick/CellRecyclerViewItemClickListener.java | 3 ++- .../itemclick/ColumnHeaderRecyclerViewItemClickListener.java | 3 ++- .../itemclick/RowHeaderRecyclerViewItemClickListener.java | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java index d3369b7e..4da79639 100644 --- a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java +++ b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java @@ -45,7 +45,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { // Get interacted view from x,y coordinate. View childView = view.findChildViewUnder(e.getX(), e.getY()); - if (childView != null && mGestureDetector.onTouchEvent(e)) { + if (childView != null) { // Find the view holder AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder (childView); @@ -72,6 +72,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { return false; } + @Override protected void longPressAction(MotionEvent e) { // Consume the action for the time when either the cell row recyclerView or // the cell recyclerView is scrolling. diff --git a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/ColumnHeaderRecyclerViewItemClickListener.java b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/ColumnHeaderRecyclerViewItemClickListener.java index e62d81da..2b623672 100644 --- a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/ColumnHeaderRecyclerViewItemClickListener.java +++ b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/ColumnHeaderRecyclerViewItemClickListener.java @@ -42,7 +42,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { // Get interacted view from x,y coordinate. View childView = view.findChildViewUnder(e.getX(), e.getY()); - if (childView != null && mGestureDetector.onTouchEvent(e)) { + if (childView != null) { // Find the view holder AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder (childView); @@ -64,6 +64,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { return false; } + @Override protected void longPressAction(MotionEvent e) { // Consume the action for the time when the recyclerView is scrolling. if (mRecyclerView.getScrollState() != RecyclerView.SCROLL_STATE_IDLE) { diff --git a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java index 605a08af..6a69bac8 100644 --- a/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java +++ b/tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java @@ -41,7 +41,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { // Get interacted view from x,y coordinate. View childView = view.findChildViewUnder(e.getX(), e.getY()); - if (childView != null && mGestureDetector.onTouchEvent(e)) { + if (childView != null) { // Find the view holder AbstractViewHolder holder = (AbstractViewHolder) mRecyclerView.getChildViewHolder (childView); @@ -62,6 +62,7 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) { return false; } + @Override protected void longPressAction(MotionEvent e) { // Consume the action for the time when the recyclerView is scrolling. if (mRecyclerView.getScrollState() != RecyclerView.SCROLL_STATE_IDLE) {