Skip to content

Commit 10251a8

Browse files
committed
chore: Check off Task 11 in multi-spec plan
1 parent 0a0e2c7 commit 10251a8

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

docs/superpowers/plans/2026-05-22-multiple-specs.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ git commit -m "feat: Add addSpec() builder method for multi-spec servers"
535535
**Files:**
536536
- Modify: `src/test/java/com/retailsvc/http/MultiSpecServerTest.java`
537537

538-
- [ ] **Step 1: Add the test**
538+
- [x] **Step 1: Add the test**
539539

540540
```java
541541
@Test
@@ -569,12 +569,12 @@ void identicalOperationIdsAcrossBindingsDispatchIndependently() throws Exception
569569
}
570570
```
571571

572-
- [ ] **Step 2: Run it**
572+
- [x] **Step 2: Run it**
573573

574574
Run: `mvn -q test -Dtest=MultiSpecServerTest#identicalOperationIdsAcrossBindingsDispatchIndependently`
575575
Expected: PASS (no production change needed — `Map<String, RequestHandler>` per binding already gives us this).
576576

577-
- [ ] **Step 3: Commit**
577+
- [x] **Step 3: Commit**
578578

579579
```bash
580580
git add src/test/java/com/retailsvc/http/MultiSpecServerTest.java
@@ -588,7 +588,7 @@ git commit -m "test: Verify identical operationIds across bindings dispatch inde
588588
**Files:**
589589
- Modify: `src/test/java/com/retailsvc/http/MultiSpecServerTest.java`
590590

591-
- [ ] **Step 1: Add the test**
591+
- [x] **Step 1: Add the test**
592592

593593
```java
594594
@Test
@@ -612,12 +612,12 @@ void rejectsTwoBindingsWithSameBasePath() {
612612
}
613613
```
614614

615-
- [ ] **Step 2: Run it**
615+
- [x] **Step 2: Run it**
616616

617617
Run: `mvn -q test -Dtest=MultiSpecServerTest#rejectsTwoBindingsWithSameBasePath`
618618
Expected: PASS.
619619

620-
- [ ] **Step 3: Commit**
620+
- [x] **Step 3: Commit**
621621

622622
```bash
623623
git add src/test/java/com/retailsvc/http/MultiSpecServerTest.java
@@ -631,7 +631,7 @@ git commit -m "test: Reject two bindings on the same basePath"
631631
**Files:**
632632
- Modify: `src/test/java/com/retailsvc/http/MultiSpecServerTest.java`
633633

634-
- [ ] **Step 1: Add the test**
634+
- [x] **Step 1: Add the test**
635635

636636
This test confirms that when a spec references a security scheme, the corresponding `SchemeValidator` must be supplied in *that binding's* validator map — not somewhere else. It uses the existing fixture which (per repo convention) declares at least one secured operation.
637637

@@ -657,12 +657,12 @@ void missingValidatorOnOneBindingFailsIndependently() {
657657
}
658658
```
659659

660-
- [ ] **Step 2: Run it**
660+
- [x] **Step 2: Run it**
661661

662662
Run: `mvn -q test -Dtest=MultiSpecServerTest#missingValidatorOnOneBindingFailsIndependently`
663663
Expected: PASS (the assumption skips if the fixture is unsecured; otherwise the wiring check fires).
664664

665-
- [ ] **Step 3: Commit**
665+
- [x] **Step 3: Commit**
666666

667667
```bash
668668
git add src/test/java/com/retailsvc/http/MultiSpecServerTest.java
@@ -676,7 +676,7 @@ git commit -m "test: Per-binding security validator wiring is enforced"
676676
**Files:**
677677
- Modify: `src/test/java/com/retailsvc/http/MultiSpecServerTest.java`
678678

679-
- [ ] **Step 1: Add the test**
679+
- [x] **Step 1: Add the test**
680680

681681
```java
682682
@Test
@@ -700,12 +700,12 @@ void rejectsMixingLegacySpecMethodsWithAddSpec() {
700700
}
701701
```
702702

703-
- [ ] **Step 2: Run it**
703+
- [x] **Step 2: Run it**
704704

705705
Run: `mvn -q test -Dtest=MultiSpecServerTest#rejectsMixingLegacySpecMethodsWithAddSpec`
706706
Expected: PASS.
707707

708-
- [ ] **Step 3: Commit**
708+
- [x] **Step 3: Commit**
709709

710710
```bash
711711
git add src/test/java/com/retailsvc/http/MultiSpecServerTest.java
@@ -721,7 +721,7 @@ git commit -m "test: Reject mixing legacy spec() with addSpec()"
721721

722722
This runs under `mvn verify` (Failsafe) and exercises real HTTP traffic.
723723

724-
- [ ] **Step 1: Write the IT**
724+
- [x] **Step 1: Write the IT**
725725

726726
```java
727727
package com.retailsvc.http;
@@ -780,12 +780,12 @@ class MultiSpecServerIT {
780780
}
781781
```
782782

783-
- [ ] **Step 2: Run it**
783+
- [x] **Step 2: Run it**
784784

785785
Run: `mvn -q verify`
786786
Expected: BUILD SUCCESS. The IT runs under Failsafe (matches `*IT.java`).
787787

788-
- [ ] **Step 3: Commit**
788+
- [x] **Step 3: Commit**
789789

790790
```bash
791791
git add src/test/java/com/retailsvc/http/MultiSpecServerIT.java
@@ -799,16 +799,16 @@ git commit -m "test: Integration test for multi-spec server under real HttpServe
799799
**Files:**
800800
- Modify: `README.md`
801801

802-
- [ ] **Step 1: Find the existing single-spec example and add a multi-spec section beneath it**
802+
- [x] **Step 1: Find the existing single-spec example and add a multi-spec section beneath it**
803803

804804
Use Read to locate the current "Quick start" or builder example in `README.md`, then add a "Multiple specs" subsection containing the example from §4 of the design doc (the `v1Spec` / `v2Spec` `addSpec` example). Keep the wording aligned with the design doc — the public contract is that each call is one binding and namespaces are per-spec.
805805

806-
- [ ] **Step 2: Run pre-commit**
806+
- [x] **Step 2: Run pre-commit**
807807

808808
Run: `pre-commit run --files README.md`
809809
Expected: PASS (editorconfig, trailing whitespace, end-of-file).
810810

811-
- [ ] **Step 3: Commit**
811+
- [x] **Step 3: Commit**
812812

813813
```bash
814814
git add README.md

0 commit comments

Comments
 (0)