refactor: Resolve SonarCloud new-code issues

- Extract MINIMUM_KEYWORD/MAXIMUM_KEYWORD constants (S1192: each literal now
  appears 3 times across the integer and number checks).
- Use an unnamed catch variable for the discarded parse exception.
- Replace try/catch + fail() with assertDoesNotThrow() in the query test.

Author: thced

src/main/java/com/retailsvc/http/validate/DefaultValidator.java

@@ -48,6 +48,8 @@
 public final class DefaultValidator implements Validator {
 
   private static final String FORMAT_KEYWORD = "format";
+  private static final String MINIMUM_KEYWORD = "minimum";
+  private static final String MAXIMUM_KEYWORD = "maximum";
   private static final Optional<ValidationError> OK = Optional.empty();
 
   private record FormatCheck(Predicate<String> isValid, String message) {}
@@ -386,7 +388,7 @@ private static Optional<ValidationError> checkInteger(
     BigInteger n;
     try {
       n = new BigDecimal(num.toString()).toBigIntegerExact();
-    } catch (ArithmeticException | NumberFormatException notIntegral) {
+    } catch (ArithmeticException | NumberFormatException _) {
       return err(pointer, "type", "expected integer", value);
     }
     return checkIntegerBounds(n, s, pointer);
@@ -395,10 +397,10 @@ private static Optional<ValidationError> checkInteger(
   private static Optional<ValidationError> checkIntegerBounds(
       long n, IntegerSchema s, String pointer) {
     if (s.minimum() != null && n < s.minimum()) {
-      return err(pointer, "minimum", "integer below minimum " + s.minimum(), n);
+      return err(pointer, MINIMUM_KEYWORD, "integer below minimum " + s.minimum(), n);
     }
     if (s.maximum() != null && n > s.maximum()) {
-      return err(pointer, "maximum", "integer above maximum " + s.maximum(), n);
+      return err(pointer, MAXIMUM_KEYWORD, "integer above maximum " + s.maximum(), n);
     }
     if (s.exclusiveMinimum() != null && n <= s.exclusiveMinimum()) {
       return err(
@@ -424,10 +426,10 @@ private static Optional<ValidationError> checkIntegerBounds(
     // Magnitude exceeds signed-long range: it breaches whichever bound lies on its side, and no
     // int32/int64 format can represent it.
     if (n.signum() > 0 && (s.maximum() != null || s.exclusiveMaximum() != null)) {
-      return err(pointer, "maximum", "integer out of range", n);
+      return err(pointer, MAXIMUM_KEYWORD, "integer out of range", n);
     }
     if (n.signum() < 0 && (s.minimum() != null || s.exclusiveMinimum() != null)) {
-      return err(pointer, "minimum", "integer out of range", n);
+      return err(pointer, MINIMUM_KEYWORD, "integer out of range", n);
     }
     if (s.format() != null && INTEGER_FORMAT_CHECKS.containsKey(s.format())) {
       return err(pointer, FORMAT_KEYWORD, INTEGER_FORMAT_CHECKS.get(s.format()).message(), n);
@@ -443,10 +445,10 @@ private static Optional<ValidationError> checkNumber(
     double n = num.doubleValue();
 
     if (s.minimum() != null && n < s.minimum().doubleValue()) {
-      return err(pointer, "minimum", "number below minimum " + s.minimum(), n);
+      return err(pointer, MINIMUM_KEYWORD, "number below minimum " + s.minimum(), n);
     }
     if (s.maximum() != null && n > s.maximum().doubleValue()) {
-      return err(pointer, "maximum", "number above maximum " + s.maximum(), n);
+      return err(pointer, MAXIMUM_KEYWORD, "number above maximum " + s.maximum(), n);
     }
     if (s.exclusiveMinimum() != null && n <= s.exclusiveMinimum().doubleValue()) {
       return err(pointer, "exclusiveMinimum", "number not greater than " + s.exclusiveMinimum(), n);

src/test/java/com/retailsvc/http/QueryParamSmugglingTest.java

@@ -2,7 +2,7 @@
 
 import static java.net.http.HttpRequest.BodyPublishers.noBody;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.fail;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 
 import com.retailsvc.http.spec.Spec;
 import java.io.InputStream;
@@ -32,21 +32,27 @@ void encodedAmpersandCannotSmuggleAValuePastQueryValidation() throws Exception {
 
   @SuppressWarnings("unchecked")
   private void constrainQ1ToLowercaseLetters() {
-    try (InputStream in = QueryParamSmugglingTest.class.getResourceAsStream("/openapi.json")) {
-      Map<String, Object> raw =
-          (Map<String, Object>)
-              gson.fromJson(new String(in.readAllBytes(), StandardCharsets.UTF_8), Map.class);
-      var paths = (Map<String, Object>) raw.get("paths");
-      var op = (Map<String, Object>) ((Map<String, Object>) paths.get("/params/query")).get("get");
-      for (Object p : (List<Object>) op.get("parameters")) {
-        var param = (Map<String, Object>) p;
-        if ("q1".equals(param.get("name"))) {
-          ((Map<String, Object>) param.get("schema")).put("pattern", "^[a-z]+$");
-        }
-      }
-      spec = Spec.from(raw);
-    } catch (Exception e) {
-      fail(e);
-    }
+    spec =
+        assertDoesNotThrow(
+            () -> {
+              try (InputStream in =
+                  QueryParamSmugglingTest.class.getResourceAsStream("/openapi.json")) {
+                Map<String, Object> raw =
+                    (Map<String, Object>)
+                        gson.fromJson(
+                            new String(in.readAllBytes(), StandardCharsets.UTF_8), Map.class);
+                var paths = (Map<String, Object>) raw.get("paths");
+                var op =
+                    (Map<String, Object>)
+                        ((Map<String, Object>) paths.get("/params/query")).get("get");
+                for (Object p : (List<Object>) op.get("parameters")) {
+                  var param = (Map<String, Object>) p;
+                  if ("q1".equals(param.get("name"))) {
+                    ((Map<String, Object>) param.get("schema")).put("pattern", "^[a-z]+$");
+                  }
+                }
+                return Spec.from(raw);
+              }
+            });
   }
 }