feat(validate): Array validation with items/minItems/maxItems/uniqueItems

Author: thced

src/main/java/com/retailsvc/http/validate/DefaultValidator.java

@@ -20,8 +20,12 @@
 import com.retailsvc.http.spec.schema.TypeName;
 import java.time.LocalDate;
 import java.time.OffsetDateTime;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
 import java.util.Map;
 import java.util.Objects;
+import java.util.Set;
 import java.util.UUID;
 import java.util.function.Function;
 import java.util.regex.Pattern;
@@ -196,7 +200,26 @@ private void validateObject(Object value, ObjectSchema s, String pointer) {
   }
 
   private void validateArray(Object value, ArraySchema s, String pointer) {
-    throw new UnsupportedOperationException("E5 implements array");
+    require(value instanceof Iterable, pointer, "type", "expected array");
+    Iterable<?> it = (Iterable<?>) value;
+    List<Object> elements = new ArrayList<>();
+    for (Object o : it) elements.add(o);
+
+    if (s.minItems() != null && elements.size() < s.minItems())
+      fail(pointer, "minItems", "fewer than " + s.minItems() + " items", elements.size());
+    if (s.maxItems() != null && elements.size() > s.maxItems())
+      fail(pointer, "maxItems", "more than " + s.maxItems() + " items", elements.size());
+
+    if (s.uniqueItems()) {
+      Set<Object> seen = new HashSet<>();
+      for (Object e : elements) {
+        if (!seen.add(e)) fail(pointer, "uniqueItems", "duplicate item", e);
+      }
+    }
+
+    for (int i = 0; i < elements.size(); i++) {
+      validate(elements.get(i), s.items(), pointer + "/" + i);
+    }
   }
 
   private static void fail(String pointer, String keyword, String message, Object rejectedValue) {

src/test/java/com/retailsvc/http/validate/ArrayValidationTest.java

@@ -0,0 +1,77 @@
+package com.retailsvc.http.validate;
+
+import static org.assertj.core.api.Assertions.assertThatCode;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import com.retailsvc.http.ValidationException;
+import com.retailsvc.http.spec.schema.ArraySchema;
+import com.retailsvc.http.spec.schema.BooleanSchema;
+import com.retailsvc.http.spec.schema.IntegerSchema;
+import com.retailsvc.http.spec.schema.Schema;
+import com.retailsvc.http.spec.schema.TypeName;
+import java.util.List;
+import java.util.Set;
+import org.junit.jupiter.api.Test;
+
+class ArrayValidationTest {
+  private final Validator v =
+      new DefaultValidator(
+          name -> {
+            throw new AssertionError();
+          });
+
+  private ArraySchema arr(Schema item, Integer minI, Integer maxI, boolean unique) {
+    return new ArraySchema(Set.of(TypeName.ARRAY), item, minI, maxI, unique);
+  }
+
+  @Test
+  void itemsValidated() {
+    var s =
+        arr(
+            new IntegerSchema(Set.of(TypeName.INTEGER), 0L, 100L, null, null, null, "int32"),
+            null,
+            null,
+            false);
+    assertThatCode(() -> v.validate(List.of(1, 2, 3), s, "")).doesNotThrowAnyException();
+    assertThatThrownBy(() -> v.validate(List.of(1, -1), s, ""))
+        .extracting(t -> ((ValidationException) t).error().pointer())
+        .isEqualTo("/1");
+  }
+
+  @Test
+  void minItemsEnforced() {
+    var s = arr(new BooleanSchema(Set.of(TypeName.BOOLEAN)), 2, null, false);
+    assertThatThrownBy(() -> v.validate(List.of(true), s, ""))
+        .extracting(t -> ((ValidationException) t).error().keyword())
+        .isEqualTo("minItems");
+  }
+
+  @Test
+  void maxItemsEnforced() {
+    var s = arr(new BooleanSchema(Set.of(TypeName.BOOLEAN)), null, 1, false);
+    assertThatThrownBy(() -> v.validate(List.of(true, false), s, ""))
+        .extracting(t -> ((ValidationException) t).error().keyword())
+        .isEqualTo("maxItems");
+  }
+
+  @Test
+  void uniqueItemsEnforced() {
+    var s =
+        arr(
+            new IntegerSchema(Set.of(TypeName.INTEGER), null, null, null, null, null, "int32"),
+            null,
+            null,
+            true);
+    assertThatThrownBy(() -> v.validate(List.of(1, 2, 1), s, ""))
+        .extracting(t -> ((ValidationException) t).error().keyword())
+        .isEqualTo("uniqueItems");
+  }
+
+  @Test
+  void rejectsNonIterable() {
+    var s = arr(new BooleanSchema(Set.of(TypeName.BOOLEAN)), null, null, false);
+    assertThatThrownBy(() -> v.validate("nope", s, "/v"))
+        .extracting(t -> ((ValidationException) t).error().keyword())
+        .isEqualTo("type");
+  }
+}