refactor: Replace inline FQN type references with proper imports

Author: thced

src/test/java/com/retailsvc/http/DecoratorAndInterceptorIT.java

@@ -7,8 +7,10 @@
 import java.net.URI;
 import java.net.http.HttpClient;
 import java.net.http.HttpRequest;
+import java.net.http.HttpResponse;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.CopyOnWriteArrayList;
 import org.junit.jupiter.api.Test;
 
 class DecoratorAndInterceptorIT extends ServerBaseTest {
@@ -66,7 +68,7 @@ void interceptorBindsScopedValueVisibleToHandler() throws Exception {
 
   @Test
   void interceptorsRunInRegistrationOrder() throws Exception {
-    List<String> trace = new java.util.concurrent.CopyOnWriteArrayList<>();
+    List<String> trace = new CopyOnWriteArrayList<>();
     RequestHandler ok =
         req -> {
           trace.add("handler");
@@ -99,7 +101,7 @@ void interceptorsRunInRegistrationOrder() throws Exception {
         .containsExactly("outer-before", "inner-before", "handler", "inner-after", "outer-after");
   }
 
-  private java.net.http.HttpResponse<String> call(String path) throws Exception {
+  private HttpResponse<String> call(String path) throws Exception {
     return HttpClient.newHttpClient()
         .send(
             HttpRequest.newBuilder()

src/test/java/com/retailsvc/http/OpenApiServerIT.java

@@ -605,8 +605,7 @@ class FormatEmail {
 
     @Test
     void formatEmailShouldReturnBadRequestOnInvalidEmail() {
-      try (var server =
-              newServer(Map.of("format-email", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-email", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?addr=not-an-email", "GET", noBody());
@@ -630,8 +629,7 @@ void formatEmailShouldReturnBadRequestOnInvalidEmail() {
 
     @Test
     void formatEmailShouldReturnOkOnValidEmail() {
-      try (var server =
-              newServer(Map.of("format-email", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-email", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?addr=user%40example.com", "GET", noBody());
@@ -657,8 +655,7 @@ class FormatByte {
 
     @Test
     void formatByteShouldReturnBadRequestOnInvalidBase64() {
-      try (var server =
-              newServer(Map.of("format-byte", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-byte", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?data=not%20base64!!", "GET", noBody());
@@ -682,8 +679,7 @@ void formatByteShouldReturnBadRequestOnInvalidBase64() {
 
     @Test
     void formatByteShouldReturnOkOnValidBase64() {
-      try (var server =
-              newServer(Map.of("format-byte", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-byte", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?data=aGVsbG8%3D", "GET", noBody());
@@ -709,8 +705,7 @@ class FormatInt32 {
 
     @Test
     void formatInt32ShouldReturnBadRequestOnOverflow() {
-      try (var server =
-              newServer(Map.of("format-int32", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-int32", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?n=2147483648", "GET", noBody());
@@ -734,8 +729,7 @@ void formatInt32ShouldReturnBadRequestOnOverflow() {
 
     @Test
     void formatInt32ShouldReturnOkOnValidValue() {
-      try (var server =
-              newServer(Map.of("format-int32", req -> com.retailsvc.http.Response.status(200)));
+      try (var server = newServer(Map.of("format-int32", req -> Response.status(200)));
           var client = httpClient()) {
 
         var request = newRequest(server, path + "?n=42", "GET", noBody());

src/test/java/com/retailsvc/http/TypeMapperRegistrationTest.java

@@ -11,6 +11,7 @@
 import java.net.http.HttpRequest;
 import java.net.http.HttpRequest.BodyPublishers;
 import java.nio.charset.StandardCharsets;
+import java.util.List;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicBoolean;
 import org.junit.jupiter.api.Test;
@@ -59,7 +60,7 @@ void userSuppliedMapperOverridesDefault() throws Exception {
           @Override
           public Object readFrom(byte[] b, String h) {
             readFromCalled.set(true);
-            return Map.of("aList", java.util.List.of("x"), "feelingGood", true);
+            return Map.of("aList", List.of("x"), "feelingGood", true);
           }
 
           @Override

src/test/java/com/retailsvc/http/spec/SpecFromPathTest.java

@@ -1,9 +1,12 @@
 package com.retailsvc.http.spec;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
+import java.nio.file.Files;
 import java.nio.file.Path;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 
 class SpecFromPathTest {
 
@@ -29,11 +32,11 @@ void loadsYamlSpecViaSnakeYaml() throws Exception {
   }
 
   @Test
-  void rejectsUnknownExtension(@org.junit.jupiter.api.io.TempDir Path tmp) throws Exception {
+  void rejectsUnknownExtension(@TempDir Path tmp) throws Exception {
     Path unknown = tmp.resolve("spec.txt");
-    java.nio.file.Files.writeString(unknown, "{}");
+    Files.writeString(unknown, "{}");
 
-    org.assertj.core.api.Assertions.assertThatThrownBy(() -> Spec.fromPath(unknown))
+    assertThatThrownBy(() -> Spec.fromPath(unknown))
         .isInstanceOf(IllegalStateException.class)
         .hasMessageContaining("Unrecognised OpenAPI spec extension");
   }