Skip to content

Commit b2640b7

Browse files
committed
fix: Unbox Boolean pattern variable before ternary in SchemaParser
Sonar java:S5411 flags using a boxed Boolean directly in a ternary as the implicit unboxing can NPE. Assign to a primitive local first so the intent is explicit and the rule passes.
1 parent e41d0d7 commit b2640b7

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/main/java/com/retailsvc/http/spec/schema/SchemaParser.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ static Map<String, Object> extractExtensions(Map<String, Object> raw) {
2424

2525
public static Schema parse(Object raw) {
2626
if (raw instanceof Boolean b) {
27-
return b ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
27+
boolean allow = b;
28+
return allow ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
2829
}
2930
if (raw instanceof Map<?, ?> map) {
3031
@SuppressWarnings("unchecked")
@@ -208,7 +209,8 @@ private static ArraySchema parseArray(Map<String, Object> raw, Set<TypeName> typ
208209
if (itemsRaw == null) {
209210
itemSchema = new NullSchema(Map.of());
210211
} else if (itemsRaw instanceof Boolean b) {
211-
itemSchema = b ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
212+
boolean allow = b;
213+
itemSchema = allow ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
212214
} else {
213215
Map<String, Object> items = (Map<String, Object>) itemsRaw;
214216
itemSchema = items.isEmpty() ? new NullSchema(Map.of()) : parse(items);

0 commit comments

Comments
 (0)