refactor(validate): Extract FORMAT_KEYWORD, use record patterns, comment empty arm

Addresses the remaining DefaultValidator SonarQube findings: deduplicates
the "format" keyword string into a constant, switches RefSchema and
AdditionalProperties.SchemaConstraint matches to record-pattern
destructuring, and adds a no-op comment to the Allowed switch arm.

Author: thced

src/main/java/com/retailsvc/http/validate/DefaultValidator.java

@@ -33,6 +33,9 @@
 import java.util.regex.Pattern;
 
 public final class DefaultValidator implements Validator {
+
+  private static final String FORMAT_KEYWORD = "format";
+
   private final Function<String, Schema> refResolver;
 
   public DefaultValidator(Function<String, Schema> refResolver) {
@@ -46,7 +49,7 @@ public void validate(Object value, Schema schema, String pointer) {
     }
 
     switch (schema) {
-      case RefSchema r -> validate(value, refResolver.apply(r.pointer()), pointer);
+      case RefSchema(String ref) -> validate(value, refResolver.apply(ref), pointer);
       case BooleanSchema _ -> validateBoolean(value, pointer);
       case NullSchema _ -> require(value == null, pointer, "type", "expected null");
       case StringSchema s -> validateString(value, s, pointer);
@@ -95,21 +98,21 @@ private void validateStringFormat(String str, String format, String pointer) {
         try {
           UUID.fromString(str);
         } catch (IllegalArgumentException _) {
-          fail(pointer, "format", "not a valid uuid", str);
+          fail(pointer, FORMAT_KEYWORD, "not a valid uuid", str);
         }
       }
       case "date" -> {
         try {
           LocalDate.parse(str);
         } catch (DateTimeParseException _) {
-          fail(pointer, "format", "not a valid date", str);
+          fail(pointer, FORMAT_KEYWORD, "not a valid date", str);
         }
       }
       case "date-time" -> {
         try {
           OffsetDateTime.parse(str);
         } catch (DateTimeParseException _) {
-          fail(pointer, "format", "not a valid date-time", str);
+          fail(pointer, FORMAT_KEYWORD, "not a valid date-time", str);
         }
       }
       default -> {
@@ -226,15 +229,17 @@ private void validateObject(Object value, ObjectSchema s, String pointer) {
         validate(entry.getValue(), propSchema, childPointer);
       } else {
         switch (s.additionalProperties()) {
-          case AdditionalProperties.Allowed _ -> {}
+          case AdditionalProperties.Allowed _ -> {
+            /* no-op: additional properties are permitted by default */
+          }
           case AdditionalProperties.Forbidden _ ->
               fail(
                   childPointer,
                   "additionalProperties",
                   "additional property not allowed",
                   entry.getKey());
-          case AdditionalProperties.SchemaConstraint sc ->
-              validate(entry.getValue(), sc.schema(), childPointer);
+          case AdditionalProperties.SchemaConstraint(Schema constraint) ->
+              validate(entry.getValue(), constraint, childPointer);
         }
       }
     }